Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp31724pxf; Tue, 6 Apr 2021 14:06:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwcQLF8oJqc4fZlUmFl0cUukhZTTap3Gyu2fGPJidskF42rAv8Yci91gUuWLqzSCdZKUZMt X-Received: by 2002:a17:906:6856:: with SMTP id a22mr13646122ejs.398.1617743204813; Tue, 06 Apr 2021 14:06:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617743204; cv=none; d=google.com; s=arc-20160816; b=eXXmBnBdYnw75FJCV8RZZqq/O8QJ0xKFpiNvRW+NYWvo/7RbD/CoGqvX5gBlEz22gM A/ZnaxjjJHpQmF0H2e/SEZwtUTMn22JVPyvKNQml28hTGjHvcd1/Fmf0/x2pPv3NiRt9 fFDqxH95jFh1C5S7c+xmr+aeoe26IHJAKkAINspsr2skSFUgAadcE3IMxTjxT8T7n8ZJ 30xX+QLZCkCl1JVKlPuz4BC00M2mdLEda0+WZBR5hNH4SFe7HGq6oT37lPSBWK20OHjJ r5T/xtYk986vDT8gk+QtV+MInTc6kYE2Cqbl0OhLwp2qQLcVlkzLSyl+m9IIm9PGAmfa N95g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=/ifo4Q8uuL4ZIXfzmQti7IaBsD5CEPJnOVDp2W7oKOs=; b=q7oEvka+NcS3TnGefBV3U8+pSxnNorxcTcjlFBq10LkPKZ5mFobJyFdMFmk1YnbtSW ++nBv5oYXFu2KIyzInl3DdB31n75Nw1d2N/7vkUyEFDYIx39yDSGKDN6TWiEkkibyTID F7ADysB0YxMUAXriXMT/b1QHEtuh56PEUVjy5psezQw7GpOb9ZhVxJgoG5KQXFwQYqYA HiseYaPpuNjej/itRMJZokz28yJHj7QIwYCI+UN9VEQyk+OD3xJ3GaNmIr13Ye0744hw I8CqR1y6CJs3bFZL7N1P/nib9BuVIeo4kBxpn3MFJ1ajvg0XahETaq5vxHOPE4IRXrPS 1CEw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m19si17841568edc.561.2021.04.06.14.06.21; Tue, 06 Apr 2021 14:06:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243007AbhDFMKW (ORCPT + 99 others); Tue, 6 Apr 2021 08:10:22 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:15557 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343731AbhDFMKL (ORCPT ); Tue, 6 Apr 2021 08:10:11 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FF5qm1W9BzPnmF; Tue, 6 Apr 2021 20:07:16 +0800 (CST) Received: from mdc.localdomain (10.175.104.57) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.498.0; Tue, 6 Apr 2021 20:09:54 +0800 From: Huang Guobin To: , Philipp Reisner , Lars Ellenberg , Jens Axboe CC: , , Subject: [PATCH -next] drbd: use DEFINE_SPINLOCK() for spinlock Date: Tue, 6 Apr 2021 20:09:48 +0800 Message-ID: <1617710988-49205-1-git-send-email-huangguobin4@huawei.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.175.104.57] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Guobin Huang spinlock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- drivers/block/drbd/drbd_main.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c index 25cd8a2f729d..d8605159240b 100644 --- a/drivers/block/drbd/drbd_main.c +++ b/drivers/block/drbd/drbd_main.c @@ -125,7 +125,7 @@ struct bio_set drbd_io_bio_set; member of struct page. */ struct page *drbd_pp_pool; -spinlock_t drbd_pp_lock; +DEFINE_SPINLOCK(drbd_pp_lock); int drbd_pp_vacant; wait_queue_head_t drbd_pp_wait; @@ -2161,9 +2161,6 @@ static int drbd_create_mempools(void) if (ret) goto Enomem; - /* drbd's page pool */ - spin_lock_init(&drbd_pp_lock); - for (i = 0; i < number; i++) { page = alloc_page(GFP_HIGHUSER); if (!page)