Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp83938pxf;
        Tue, 6 Apr 2021 15:43:41 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzRcu7DcZYp/yixbjVC3ynzV+y1vUHP0WuIRSX3YtZnR20oIYHS2cGH/XSavEBJDPl6ty6v
X-Received: by 2002:a6b:b447:: with SMTP id d68mr128436iof.87.1617749021508;
        Tue, 06 Apr 2021 15:43:41 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1617749021; cv=none;
        d=google.com; s=arc-20160816;
        b=rsRpR9Vu18HqTTOHYPaCrE3Ci2/itqW4LPYczv7RpZqlLMvfhzkCH+FimlDmpj0p38
         I5HHxYo8OyPVIGFe0/WZweK4VYvlif5lrC5l3+2v+3xqq4YCnB9vxzew2VeeoOo+EYiW
         D8/PldcoYy/epRUNpyIALMDg22Dck7NONsOqCIrBIyus6IHt9dOw9urvjMJBt68c2w7d
         R+Uuw0V/W8I9wuKe6KEzHr1OxatGRtBW4pMzPJmupI8unC91Fdi8pzPs8QbuVsIF88PQ
         Gtov3NoFnOuAUzgJPcCpfpsd8+OAa7AL1lV3qbarv1E/cHsHEQLno+VYy8lX/HOcz7yp
         lbEA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=+7/Yy8FyGH5pK5mRz0l5jSVYfRzX9mnUy8rv/og0Li0=;
        b=QJKnjX3PN2AkGttIAWEoPkrC/kirhtIe/XSyQgs81vntY616xw0eO4d+Ag0qLdrF5K
         0JUQgL7LXUnv5+ZC/L6Yl9tAWbB1nh8HVJ/rZ0CvYuKALe9eofZ/N9LNSkuPxZ9B09xE
         KIDzpD+l0E3tgdZ+5bcd2noR9JjfHUFJVvqhIgpaL1zyv9xj5YQ8v0k6uYb3kpnC7Hig
         +Plj5Yw5DrsVlXKiYsBMntwEV5exyZRM9m5K7Z1bF4eomka7TwhRa5m/fYoKMPVEIAJY
         uVeyFgHWl+HVeFJF7MbXsHwNAc+ARfFqpy0mTkhzHxYsJE4L/4Aqi1VBIf2E4naHtVnT
         U1wQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=vxnrURPk;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id y14si9924268ilj.76.2021.04.06.15.43.18;
        Tue, 06 Apr 2021 15:43:41 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=vxnrURPk;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1344577AbhDFNkT (ORCPT <rfc822;linuxmindflow@gmail.com>
        + 99 others); Tue, 6 Apr 2021 09:40:19 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60750 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S238827AbhDFNkS (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 6 Apr 2021 09:40:18 -0400
Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83DAFC06174A;
        Tue,  6 Apr 2021 06:40:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=+7/Yy8FyGH5pK5mRz0l5jSVYfRzX9mnUy8rv/og0Li0=; b=vxnrURPk4ZMdXwdWGpKk5XuPbF
        l3xFtxxPz2vTtazTcxXpf7AYJ3llp958/TUesie5bfi48mmp5RTgwD9YF8SnpubF/ONM3aKM/1ZBX
        qcSK5qr8yTxPzxySQI8lCgz55JDu821gmVEyzENzFhvrOurypJclIu5grnwFOVl4ASaikuotYYWqA
        ZDV+3WBApfl6evy6wR4r9GWnfwPDFUHeUfY5geb4L0ZQn/PynH2UFbyBO8sMxrcSS52q6tGHBo9RN
        kjkK+2nR5Ez036FznOaZhNCiZASDlc+s14u9r5twSgtAjJL6nM4ZCc0jXmegS8LdMPYqbSt+ljNMw
        fyX8iwMQ==;
Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux))
        id 1lTlvD-00CsBg-F2; Tue, 06 Apr 2021 13:39:14 +0000
Date:   Tue, 6 Apr 2021 14:39:11 +0100
From:   Christoph Hellwig <hch@infradead.org>
To:     "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com,
        linux-afs@lists.infradead.org
Subject: Re: [PATCH v6 10/27] mm/filemap: Add folio_index, folio_file_page
 and folio_contains
Message-ID: <20210406133911.GI3062550@infradead.org>
References: <20210331184728.1188084-1-willy@infradead.org>
 <20210331184728.1188084-11-willy@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210331184728.1188084-11-willy@infradead.org>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by casper.infradead.org. See http://www.infradead.org/rpr.html
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Except for the implementation details using the unions field (I'm not
going to mention these going forward), this looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>