Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp88552pxf; Tue, 6 Apr 2021 15:54:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxi2+NIxzZLz1RzV4Gf+Wh9XqJa4P7NMJQpkcuHyYXQslggwP0+jxf4dJrgIaTKNxds+NRw X-Received: by 2002:a17:907:70cd:: with SMTP id yk13mr346347ejb.233.1617749648912; Tue, 06 Apr 2021 15:54:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617749648; cv=none; d=google.com; s=arc-20160816; b=QLH8+I2Z8pw28Feyzaa7EhJbM0l1e1AdHso5MIKzb0TNkoMGB9xfXt5Iyvl/HjJs2y w3knkAxI91S5EXGgtRldCMiDdrVxtplGbk8m5heKKOY1uxDQnImBvv3LrW7S3H1jwvey SXm8vfHN2tJ4q/crhR8hrbn8jG+sk+bQIxX9gAJTpcuDin6JvG/4PL8Y2nyjgEzVzcs1 u8b9W0iyseeolxzY1c6/M+ro6XRltxRRCqKTWslZ3lcJ4qoSlWFNz5wZ0Ah7a0Y77SRX xtcjPAwVWrihp25ot3h0/FwVBDdh0IPsXGg/Fw9L84pLwrG+YMk1JUdgMfolaLZh3aiG A3Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=xdVYuW+gbiOxbxB3U0bNC9sVbHKkGQf7dwoQZGExKhc=; b=bfu1D49FzCMRUvwwS/iPDVDW2yyjq53nEwZEuRjgJynRTI0sMyrjnEEC1N+i+Avb8U BRZ7vkyGcgO2UqMGkhHga3Uc9XwybeMY1C5CW7j8W1t89l9Fp/dtgEKiq68ew455sdqs nxQ+0ka5l4+mgkEPr0oHq0Zj+w6hcHRkR5BmlrL7Rh/WHag10Qt2YWZbPcTCW4oylSEY UZVuDQ9c2e+zYC2drWx4zzlfoZxKur1YNUq/zOlTHjiAEa6qikiy360/hnntoRZOUzfu aJwdqUTUocJUo6Gr4jrwrm1tFcYM4O//HQ74NKVwnhMoLyLEN4IQ8iH4rEL9Aq1jv1+p DI3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=f2t37RoJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o12si6063016edv.501.2021.04.06.15.53.46; Tue, 06 Apr 2021 15:54:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=f2t37RoJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344813AbhDFN6g (ORCPT + 99 others); Tue, 6 Apr 2021 09:58:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234701AbhDFN6f (ORCPT ); Tue, 6 Apr 2021 09:58:35 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5A19C06174A; Tue, 6 Apr 2021 06:58:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xdVYuW+gbiOxbxB3U0bNC9sVbHKkGQf7dwoQZGExKhc=; b=f2t37RoJlqsBWWtrooL30jycBF W1dHpBPK3mMoOjz9PBOz8+c9HTnI82yJ7QjqteYXeTAwQEQ0JhAZ6dS1Ua3S2AyJdHMUJ/nxgKD/+ CDYPRWODGkkshW+jSh+0NClqFx8WKgf4v0qqcBvXHJS6NNf5onKza36rE6h9QCUkjdA16gTAv+76O RxGyvZDivjlqwnstHpTZ5vypMVd/uLER8ZHYSWsLb0c8g7I+WqVHzHdt19/5vnmoRsv7IfOfSwFGA JY4B9wh/nKTu6NXHnDGy9SuIkVlhwpcnNgFGu5J2d4WChMG+++srgp1oLBR1quy55/BxwLjHCsKGo i3+q7wcg==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lTmCr-00CtiQ-JT; Tue, 06 Apr 2021 13:57:32 +0000 Date: Tue, 6 Apr 2021 14:57:25 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, linux-afs@lists.infradead.org Subject: Re: [PATCH v6 20/27] mm/filemap: Add __lock_folio_or_retry Message-ID: <20210406135725.GS3062550@infradead.org> References: <20210331184728.1188084-1-willy@infradead.org> <20210331184728.1188084-21-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210331184728.1188084-21-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 31, 2021 at 07:47:21PM +0100, Matthew Wilcox (Oracle) wrote: > Convert __lock_page_or_retry() to __lock_folio_or_retry(). This actually > saves 4 bytes in the only caller of lock_page_or_retry() (due to better > register allocation) and saves the 20 byte cost of calling page_folio() > in __lock_folio_or_retry() for a total saving of 24 bytes. Looks good, Reviewed-by: Christoph Hellwig