Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp114779pxf; Tue, 6 Apr 2021 16:41:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxyfsEZNabdkIUB2nPhIRnF9jxbKziUmmnn4cw+5cgXM7qaCdtrp3mC0w+yspe7Z59UczcW X-Received: by 2002:a17:906:a049:: with SMTP id bg9mr585582ejb.186.1617752510162; Tue, 06 Apr 2021 16:41:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617752510; cv=none; d=google.com; s=arc-20160816; b=uuMNV7R4mrykCcqy277SG2EnyNmAxA70MF/E+3nro5t9TZDb6M2lLlH64AQ3PuHppj 8yDQ+pgVn7ajmdOTdyncCZgf4+HWW3FSUsrQLdthLxdxOVse4F3ybm4Og5wogChw+DgK DXYv43YXICDcBLzs/On70EqA4/UCat4GpnNUcF8ilmOSVVZwFVhyU9n1PsqUvUK2x5NU 55QNGke5n8+891PlaOltmULSIgmYvevbzxDiwmlr4Hs926OxYiJnHeVtgb1ngwYf75U9 RBrOgXE4oQPEGTYhnRdS5axdiJo/8CgQOORSwT30Pl61BOhh0Olsben5/l329V0N3L2s C89w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Xqub4sjt54FzRQ/fvsCh/tHtwz+sQViLhigZ2eLngb4=; b=xNeKpBoBFXzIy3UOgVszTKlqbM1F93J/+HSIYAJF6InTrRtAsC3FDoYVYCGiKZoskD iCQOMbLcSjoVZkwvd9PTNHDi7DCEFFZJVeUS7M6TWLqQtgyLOlopv134WoMzHE33tNWc MGE4zABngd0Gc7OT6lnGHez9TpmCSJGOqDZMJWbE6CIJqoC5V/uFjfIT2IjVeyUxek4Y u9Uzgkz1dQqXTPIAjR8JpHHMX5s5GwMPWQMRF1PYlaittv7fh7jW7yG64CtNMQKE0FnZ 9PdXy8V6UNTJQckTM95fe3AtwY41xA6KtLY1Y0CYIu7ldEdlOkPBFuagxTYay/CyKdUU Kusg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=r9rPmSK1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f12si4264668edw.18.2021.04.06.16.41.26; Tue, 06 Apr 2021 16:41:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=r9rPmSK1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245195AbhDFKu6 (ORCPT + 99 others); Tue, 6 Apr 2021 06:50:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236135AbhDFKuy (ORCPT ); Tue, 6 Apr 2021 06:50:54 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1A67C06175F for ; Tue, 6 Apr 2021 03:50:46 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id 184so15942419ljf.9 for ; Tue, 06 Apr 2021 03:50:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Xqub4sjt54FzRQ/fvsCh/tHtwz+sQViLhigZ2eLngb4=; b=r9rPmSK181dTzIRu5W6qSmFwkzrtbKfqQSHTA3t6rYq2A+KdxCyylz2wmxcThUHcUE zThVGoqkt8SQA50Zc6kr47yE2tjG0BP4l/cghORZC8K/kHnQ7iunzjyZx0/xD3rOULv4 89vbMiwn97pRzkhg43f6gpS8hfl3ppLDIFWhSyvnb0TEogtduBjTjyYkxatAGQRAekPq MiiFS74b2EEwG5IoBjT+kzfLeWLXkn2ihPft6fK2RlUPUyG+ZHMjk2bEz4v0uJpuVZmn TrO33fcnu99LSnzwUMDv7j2fArKcgROp5aF2UvrasSeblJztqvtW1s5GmjvmtA89u6/P XPQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Xqub4sjt54FzRQ/fvsCh/tHtwz+sQViLhigZ2eLngb4=; b=CbNwiQBJI6IsMJ3dvQVZme7zo24HynJ9G9A4/qKypdrnHU6kwomLsebWB/Kw09QdH4 Km7RI/QQrYVUVDhLFYW3EPMc43syFYOn0GiNV7XPHSPc5Yq9LKMet+5qsKsW2ayp0T0I offUX5gFuwTd0Hz3mYyKm8TUg7Xfe3quCmKIlg/eirUa5JkuVE3QJam5zNvj29hS7VaK 9Bj4RjWGGt85FR/oOZat/mXaG6pPhDq7/WR5WXVK8RU5EgsVBVUgRDqFxw9o/Pu9gWG/ NokP0AK2VFT3J/dvYFg8N7vmM7jtm0fYz4evr/CZ5wiezIK1bHWJK1844AjsnItFCyQ3 p2uQ== X-Gm-Message-State: AOAM533DwZe5DAAokTAoZGjqt6fi0MqXghiH2ql536YxqccmnLdu+sEH yKZBSbnu5Up/I5BWsaQio8Y0fajqiSihyg== X-Received: by 2002:a2e:9cd5:: with SMTP id g21mr17846362ljj.367.1617706245555; Tue, 06 Apr 2021 03:50:45 -0700 (PDT) Received: from zhans ([37.151.32.231]) by smtp.gmail.com with ESMTPSA id e15sm2235374ljg.54.2021.04.06.03.50.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 03:50:44 -0700 (PDT) Date: Tue, 6 Apr 2021 16:50:34 +0600 From: Zhansaya Bagdauletkyzy To: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com, gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: [PATCH 1/2] staging: rtl8712: Rewrite NULL comparisons Message-ID: <5d2db1d233030ececcdd4934ca9c46cb998c0c5b.1617705825.git.zhansayabagdaulet@gmail.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Replace NULL comparisons with boolean negation. Reported by checkpatch. Signed-off-by: Zhansaya Bagdauletkyzy --- drivers/staging/rtl8712/rtl871x_recv.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_recv.h b/drivers/staging/rtl8712/rtl871x_recv.h index 7c9995060a6f..4aa39f4f3b84 100644 --- a/drivers/staging/rtl8712/rtl871x_recv.h +++ b/drivers/staging/rtl8712/rtl871x_recv.h @@ -135,7 +135,7 @@ int recv_func(struct _adapter *padapter, void *pcontext); static inline u8 *get_rxmem(union recv_frame *precvframe) { /* always return rx_head... */ - if (precvframe == NULL) + if (!precvframe) return NULL; return precvframe->u.hdr.rx_head; } @@ -143,7 +143,7 @@ static inline u8 *get_rxmem(union recv_frame *precvframe) static inline u8 *get_recvframe_data(union recv_frame *precvframe) { /* always return rx_data */ - if (precvframe == NULL) + if (!precvframe) return NULL; return precvframe->u.hdr.rx_data; } @@ -153,7 +153,7 @@ static inline u8 *recvframe_pull(union recv_frame *precvframe, sint sz) /* used for extract sz bytes from rx_data, update rx_data and return * the updated rx_data to the caller */ - if (precvframe == NULL) + if (!precvframe) return NULL; precvframe->u.hdr.rx_data += sz; if (precvframe->u.hdr.rx_data > precvframe->u.hdr.rx_tail) { @@ -170,7 +170,7 @@ static inline u8 *recvframe_put(union recv_frame *precvframe, sint sz) * return the updated rx_tail to the caller * after putting, rx_tail must be still larger than rx_end. */ - if (precvframe == NULL) + if (!precvframe) return NULL; precvframe->u.hdr.rx_tail += sz; if (precvframe->u.hdr.rx_tail > precvframe->u.hdr.rx_end) { @@ -188,7 +188,7 @@ static inline u8 *recvframe_pull_tail(union recv_frame *precvframe, sint sz) * updated rx_end to the caller * after pulling, rx_end must be still larger than rx_data. */ - if (precvframe == NULL) + if (!precvframe) return NULL; precvframe->u.hdr.rx_tail -= sz; if (precvframe->u.hdr.rx_tail < precvframe->u.hdr.rx_data) { -- 2.25.1