Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp153193pxf; Tue, 6 Apr 2021 17:54:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx1H5B6VqtbHWV4khRkgnb1SwYdWnqbT3Hxz5oe0sEvzr4VVWdkhDnAUPL5YMyZ8nIQH7VF X-Received: by 2002:a05:6602:2094:: with SMTP id a20mr470635ioa.19.1617756896547; Tue, 06 Apr 2021 17:54:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617756896; cv=none; d=google.com; s=arc-20160816; b=lKSNceCcdkB2spBUVHAzVddmYhJUAYv4EBzo2iT1ACJ6YqgJWafwe199sZI+w4NByJ nQB2CmTmPst/Q8AE0uVoIm2Cq2/PjBVx3tGdrFOLrJp7nMVriv9Quv3PU+/jko6G+k37 KLHCPeMa1kej1xRK0or3PcUq/LDz5y3yrlZXXNqUzpHXTpXUDcpLlJ/9mAxg4uCJ0vR8 Zl0VgaVMkaMRJVsS86Ni2wfsr29lH6+d9C4Zy+CGNDocu2qb3C8lWO1wPik1su9+sAQZ /7PtJBX8iUgSvq0xTVL1Pq61McwzxNpxP6UInrwU/PZjDJqpLarOx/jX3UQI3MFO6O9T 5FMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=as/0Z/5wr9TkrGQbVDRqvZhLAp0fADIbecLscNasQB0=; b=maF+qx05kIM303PtBrZjvzjoeIptTEUmqsf7fYXoW2Z8EjzbSI7db2C4oj+qPcd3Qi r/mI3KpOGznBV/51+TXQQ3SgKkhK0E3/rt/cTcBPA7CS90/k9lmWFlDH+QTRh1YK2YJG xdXmgXKDmU/CBJ+ux7zltP8pNkEoJY5+u9ywu+pF04mYf0yehicJDrxHnNpFNgEdSeHQ rFftVqbQkBcnl2PrKh9XUjLyXUIB1OHZn9wEahub5r8wT4HU7o9qvJkEf6UVTkqu/oBC Q6VTzC1ohCvZq1GXL7k4oAPi86no1qt1aua2NmTd/1MYPhIEqb2L16iqLMddzg0WempX yeAg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m7si20444251ilu.125.2021.04.06.17.54.42; Tue, 06 Apr 2021 17:54:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245564AbhDFL17 (ORCPT + 99 others); Tue, 6 Apr 2021 07:27:59 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:16356 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245477AbhDFL1o (ORCPT ); Tue, 6 Apr 2021 07:27:44 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4FF4vQ1LFvz949N; Tue, 6 Apr 2021 19:25:22 +0800 (CST) Received: from localhost.localdomain (10.67.165.24) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.498.0; Tue, 6 Apr 2021 19:27:24 +0800 From: Xiaofei Tan To: , CC: , , Xiaofei Tan Subject: [PATCH v2 03/10] tty: tty_jobctrl: Add a blank line after declarations Date: Tue, 6 Apr 2021 19:24:41 +0800 Message-ID: <1617708288-14847-4-git-send-email-tanxiaofei@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1617708288-14847-1-git-send-email-tanxiaofei@huawei.com> References: <1617708288-14847-1-git-send-email-tanxiaofei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add a blank line after declarations, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_jobctrl.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/tty/tty_jobctrl.c b/drivers/tty/tty_jobctrl.c index 4b751b9..86070f7 100644 --- a/drivers/tty/tty_jobctrl.c +++ b/drivers/tty/tty_jobctrl.c @@ -75,6 +75,7 @@ void proc_clear_tty(struct task_struct *p) { unsigned long flags; struct tty_struct *tty; + spin_lock_irqsave(&p->sighand->siglock, flags); tty = p->signal->tty; p->signal->tty = NULL; @@ -173,6 +174,7 @@ EXPORT_SYMBOL_GPL(get_current_tty); void session_clear_tty(struct pid *session) { struct task_struct *p; + do_each_pid_task(session, PIDTYPE_SID, p) { proc_clear_tty(p); } while_each_pid_task(session, PIDTYPE_SID, p); @@ -269,6 +271,7 @@ void disassociate_ctty(int on_exit) tty_vhangup_session(tty); } else { struct pid *tty_pgrp = tty_get_pgrp(tty); + if (tty_pgrp) { kill_pgrp(tty_pgrp, SIGHUP, on_exit); if (!on_exit) @@ -280,6 +283,7 @@ void disassociate_ctty(int on_exit) } else if (on_exit) { struct pid *old_pgrp; + spin_lock_irq(¤t->sighand->siglock); old_pgrp = current->signal->tty_old_pgrp; current->signal->tty_old_pgrp = NULL; @@ -328,6 +332,7 @@ void no_tty(void) between a new association and proc_clear_tty but possible we need to protect against this anyway */ struct task_struct *tsk = current; + disassociate_ctty(0); proc_clear_tty(tsk); } -- 2.8.1