Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 6 Apr 2021 15:01:33 +0200
From:   Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To:     Christoph Hellwig <hch@lst.de>
Cc:     Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/4] MIPS: Remove get_fs/set_fs
Message-ID: <20210406130133.GB9505@alpha.franken.de>
References: <20210401125639.42963-1-tsbogend@alpha.franken.de>
 <20210406072443.GA7626@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210406072443.GA7626@lst.de>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Tue, Apr 06, 2021 at 09:24:43AM +0200, Christoph Hellwig wrote:
> Btw, there is a bunch of cleanups that would fit in nicely on top of
> this:
> 
>  - remove the unused __invoke_copy_from function

I've removed in the last patch before applying to mips-next.

>  - fold __get_user_check into get_user as it is the only caller
>  - fold __get_user_nocheck into __get_user as it is the only caller
>  - fold __put_user_check into put_user as it is the only caller
>  - fold __put_user_nocheck into __put_user as it is the only caller
>  - implement get_user in terms of __get_user to document the difference
>    better and to remove __get_user_common
>  - implement put_user in terms of __put_user to document the difference
>    better and to remove __get_user_common
>  - remove __put_user_unknown/__get_user_unknown and replace them with
>    BUILD_BUG_ON()

I'll prepare a follow-up patch. Thank you for your cleanup hints.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]