Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.62.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com;
Envelope-to: git@xilinx.com,
 linux-kernel@vger.kernel.org,
 linux-ide@vger.kernel.org,
 axboe@kernel.dk
Subject: Re: [PATCH V2] ata: ahci: ceva: Updated code by using dev_err_probe()
To:     Piyush Mehta <piyush.mehta@xilinx.com>, <axboe@kernel.dk>
CC:     <linux-ide@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <git@xilinx.com>, <sgoud@xilinx.com>, <michal.simek@xilinx.com>
References: <20210305091029.23378-1-piyush.mehta@xilinx.com>
From:   Michal Simek <michal.simek@xilinx.com>
Message-ID: <6c485429-62a4-608f-6600-4e1f6e88c4e0@xilinx.com>
Date:   Tue, 6 Apr 2021 16:11:30 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: <20210305091029.23378-1-piyush.mehta@xilinx.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2021 14:11:35.0108
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 63ff816e-1c57-42a1-06b6-08d8f905e300
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource: BL2NAM02FT040.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB6345
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jens,

On 3/5/21 10:10 AM, Piyush Mehta wrote:
> Updated code with already prepared dev_err_probe(). It reduces code size
> and simplifies EPROBE_DEFER handling.
> 
> Also, unify message format for similar error cases.
> 
> Signed-off-by: Piyush Mehta <piyush.mehta@xilinx.com>
> Acked-by: Michal Simek <michal.simek@xilinx.com>
> ---
> This patch is based on ahci-ceva patches:
> https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-next&id=5542fabd9e07d6c49c07862e73070c325f93d390
> 
> Tree: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/tree/?h=for-next
> 
> Changes for V2:
> - Address review comment- remove curly brackets {}. 
> ---
>  drivers/ata/ahci_ceva.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/ata/ahci_ceva.c b/drivers/ata/ahci_ceva.c
> index b980218..50b56cd 100644
> --- a/drivers/ata/ahci_ceva.c
> +++ b/drivers/ata/ahci_ceva.c
> @@ -206,11 +206,9 @@ static int ceva_ahci_probe(struct platform_device *pdev)
>  
>  	cevapriv->rst = devm_reset_control_get_optional_exclusive(&pdev->dev,
>  								  NULL);
> -	if (IS_ERR(cevapriv->rst)) {
> -		if (PTR_ERR(cevapriv->rst) != -EPROBE_DEFER)
> -			dev_err(&pdev->dev, "failed to get reset: %ld\n",
> -				PTR_ERR(cevapriv->rst));
> -	}
> +	if (IS_ERR(cevapriv->rst))
> +		dev_err_probe(&pdev->dev, PTR_ERR(cevapriv->rst),
> +			      "failed to get reset\n");
>  
>  	hpriv = ahci_platform_get_resources(pdev, 0);
>  	if (IS_ERR(hpriv))
> 

Can you please apply this to your tree?

Thanks,
Michal