Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp268874pxf; Tue, 6 Apr 2021 21:55:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxcg+wzLsfSllzbNMiCZQV/7XkkgLv5G6kIiBO7bS4+NPWbUtloDaqS2KwjZslA0Ve4HqK7 X-Received: by 2002:a6b:6e06:: with SMTP id d6mr1071763ioh.116.1617771343422; Tue, 06 Apr 2021 21:55:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617771343; cv=none; d=google.com; s=arc-20160816; b=xgeZlAFkhMFJjudfjrD1FmRE1V96THb6rVGuUBnBiHD7TJC1EcOysA1qkuVmKTvp5n kQIqzOcfV/1oZy28WhKRFPZXoZG6Fx42Zt/fQDweyrec+xIig5flexztRf7gabKk80sJ DgZDBJ8K1ZpnsYso8E2fgtBFDC/9uSTr7e6ZreSU8X2qAKkycyz398s+1mQP3AZqnVwu 2sFxNUYv17Druj1g/dPPAxUZLShXj9Fed0tey/NeSo/HFmj68tbPlyApR0cEuxge2D17 FF+lDHfqMXpnjOcQLBMYMR8kJkYSqtyNLm8gFZLNK/1dTNcPVVQa/eCpnfPmy+ppVinI g87A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=pZwMcf5iEm9vQedhznNSrB1eoBlpxK0vTkFxcd3+VS4=; b=mMjDWgjBBZBVJc/4/491+GC4hfPXlJ62eIIE1fLp8ZiuQ6qhfAJnK3EVWGEr1ElL3m DIy68kHVs0s/+IVP4N2rsJ9s02YQlctjhbhkOB9Q3gAHxZ81A1/767l5uwVFTzJn4yCH 13ZBksTXZqkBeD0MspjscFUzocqlnfeHWRou8g2clulDcphspy8FiI2NJCUqX1PEIIlR XOFo/0/rWhH2GcHNRS0H80O/abKj4+R7PmrXYOdytuddlk15h4S4B2D8jVDv1whAaJ6O 06OK6U1sP9IS846/ExXsN+utYKRzUofHeSOoqN4oSsTOAtNbIsEqVQiluBlR9u7Ccxu3 RnOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=fCLis4aR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u5si19136082ill.119.2021.04.06.21.55.31; Tue, 06 Apr 2021 21:55:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=fCLis4aR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344916AbhDFONh (ORCPT + 99 others); Tue, 6 Apr 2021 10:13:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344891AbhDFONZ (ORCPT ); Tue, 6 Apr 2021 10:13:25 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF99FC06174A; Tue, 6 Apr 2021 07:13:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=pZwMcf5iEm9vQedhznNSrB1eoBlpxK0vTkFxcd3+VS4=; b=fCLis4aRjdezyDv5mCGo2tcDKb /AR6CsS8iGBK+ThwUJMuULlVAdDQeN+Rmlex9MFGZisePOqgXNQc75EAcPGIrjJBLtp+JgHU7uY2B 2emgSSuq+jO6ayyxTR85dlGVBsWYGiw7GGtEcZHtZMhMVSlG6oc47q4iVx/orrKOTHVwXApxp25z3 SsBTeJkKze3KLs5dfdAJ0SM58KVMz2trc2ExJhm/OMdoqxgWfP7oGHKdvJMkgeat/ID0uyHa0qB5j BYo2KlA3pI3KSXUxBX0dl1BwiVWQ/blR2F9+joYd/hnqH37P27I0WFubF503vmc6Tgk+H6/kAaLXl r/dvou2Q==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lTmQp-00Cukf-Ls; Tue, 06 Apr 2021 14:12:11 +0000 Date: Tue, 6 Apr 2021 15:11:51 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, linux-afs@lists.infradead.org Subject: Re: [PATCH v6 21/27] mm/filemap: Add wait_on_folio_locked Message-ID: <20210406141151.GT3062550@infradead.org> References: <20210331184728.1188084-1-willy@infradead.org> <20210331184728.1188084-22-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210331184728.1188084-22-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 31, 2021 at 07:47:22PM +0100, Matthew Wilcox (Oracle) wrote: > Also add wait_on_folio_locked_killable(). Turn wait_on_page_locked() > and wait_on_page_locked_killable() into wrappers. This eliminates a > call to compound_head() from each call-site, reducing text size by 200 > bytes for me. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good, Reviewed-by: Christoph Hellwig