Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] xen/evtchn: Change irq_info lock to raw_spinlock_t
To:     Luca Fancellu <luca.fancellu@arm.com>, sstabellini@kernel.org,
        jgross@suse.com, jgrall@amazon.com
Cc:     boris.ostrovsky@oracle.com, tglx@linutronix.de, wei.liu@kernel.org,
        jbeulich@suse.com, yyankovskyi@gmail.com,
        xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org, bertrand.marquis@arm.com
References: <20210406105105.10141-1-luca.fancellu@arm.com>
From:   Julien Grall <julien@xen.org>
Message-ID: <74349f41-ba4e-7486-5467-fb8fa3c96e50@xen.org>
Date:   Tue, 6 Apr 2021 14:46:31 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: <20210406105105.10141-1-luca.fancellu@arm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Luca,

On 06/04/2021 11:51, Luca Fancellu wrote:
> Unmask operation must be called with interrupt disabled,
> on preempt_rt spin_lock_irqsave/spin_unlock_irqrestore
> don't disable/enable interrupts, so use raw_* implementation
> and change lock variable in struct irq_info from spinlock_t
> to raw_spinlock_t
> 
> Cc: stable@vger.kernel.org
> Fixes: 25da4618af24 ("xen/events: don't unmask an event channel
> when an eoi is pending")
> 
> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>

Reviewed-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall