Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp287411pxf; Tue, 6 Apr 2021 22:36:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy1ui/l0vS4yjOXP71g6Yk+UP3sQgVXgTI26my2UoEM+5su/tbKUdQ068p6zzVxxp7RckqC X-Received: by 2002:a05:6e02:12cc:: with SMTP id i12mr1538048ilm.10.1617773773156; Tue, 06 Apr 2021 22:36:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617773773; cv=none; d=google.com; s=arc-20160816; b=jXQPuSlttg+NXB/XdLmeMHzk14Py7cGKZ9DiqP4Sxhnv8AOwqXjS8UMrAthv5XKa1q AwmZh89n1DebSU1QaI4uRfJmANwDMdgVHpldeDutvYltyl4fwOpkzEFtxBaAlDZOWK95 hCjP0ZBKJP9WRcMtKZWTNl0uDyS53Bm2m/Gaq/efpyS1q0d8VhGjFDjK/9OPj3i/XCff W/2v5eiwiVpDt+irLLQ8QqOdPlAbs11Y2S59olrhj2bbiFVXdi98qTc+BCClfMuPXdW7 u0u3jQm047ZyYZModL2e6DxELX2eYTFL21ZWe3gv3hnJQWwXWu122Qokw0OnjsjKaQ8B SOUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:in-reply-to:subject :cc:to:from:user-agent:references:ironport-sdr:ironport-sdr; bh=vDXVYfglB9jDbdEotMxY2tZWtVduAN02xqC0tYDzLtk=; b=r5OCO8sKI2xdYb4AtZQv4CluvwO157O883Tn3jHABvmiGF30azH/wJejmvsUUuF3W1 jVQp88W+1XHShYqzlC0hr+7Hb/mTIB9I7PBqReL/dU5b/7JU+etFeDblyTDLSzMAkO0v c5oWrAq8y+qaZNkw5bthuvOF5cSjLJdYjs5V/aX6m5rP+BiQcxboC/jgt0Tg2gRk/CxN iOMSfIgnzAMKHPG2M2ywUYD/lGslVHgZ8FGQlgzcl6VczP6jDXDUbkfc7NTkO6MgD88X qfWEfpQjtnq/kQNKLIB2FIA4V+M9a+NoqnJ2hmJnWyi9xu715Stjk4ETcz8PcWGmTur1 MkaQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e12si19775561ilq.94.2021.04.06.22.36.01; Tue, 06 Apr 2021 22:36:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345364AbhDFO6g (ORCPT + 99 others); Tue, 6 Apr 2021 10:58:36 -0400 Received: from mga02.intel.com ([134.134.136.20]:39841 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233155AbhDFO6f (ORCPT ); Tue, 6 Apr 2021 10:58:35 -0400 IronPort-SDR: DVbJorUWv6hFl/uJAqjtTuRQKzV9PF8LL2bgZx41Vqry2Dz1/xSu3ZpjRZaBkYPGCXZjP9rNpK Smg8sLMithYA== X-IronPort-AV: E=McAfee;i="6000,8403,9946"; a="180212868" X-IronPort-AV: E=Sophos;i="5.81,309,1610438400"; d="scan'208";a="180212868" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2021 07:58:17 -0700 IronPort-SDR: fiFrUVJOYBijNDSYd8YfSnVrVO43Eiwcw7E79dUIh9AmdPS/0mn11FiveoK1e64UsqswJHiCu7 P4dGbcu4gEtA== X-IronPort-AV: E=Sophos;i="5.81,309,1610438400"; d="scan'208";a="519067118" Received: from gna-dev.igk.intel.com (HELO localhost) ([10.102.80.34]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2021 07:58:14 -0700 References: <20210324183610.4574-1-maciej.kwapulinski@linux.intel.com> <20210324183610.4574-3-maciej.kwapulinski@linux.intel.com> User-agent: mu4e 1.4.13; emacs 26.3 From: Maciej Kwapulinski To: Andy Shevchenko Cc: Greg Kroah-Hartman , Arnd Bergmann , Jonathan Corbet , Derek Kiernan , Dragan Cvetic , Linux Kernel Mailing List , Linux Documentation List , Tomasz Jankowski , Savo Novakovic , Jianxun Zhang Subject: Re: [PATCH v2 02/13] intel_gna: add component of hardware operation In-reply-to: Date: Tue, 06 Apr 2021 16:58:12 +0200 Message-ID: <85wntfo3y3.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andy Shevchenko writes: > On Wed, Mar 24, 2021 at 8:38 PM Maciej Kwapulinski > wrote: >> +#define gna_reg_write(addr, offset, value) writel((value), (addr) + (offset)) > > No point And make them functions, not macros. > >> + >> +#endif // __GNA_HW_H__ >> -- >> 2.28.0 >> Andy, Thank You for all Your comments on these two patches. I'm starting to work with them. Just as with v1 patch series, I'll get back to You in case of any questions Regards, Maciej