Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210405191757.283122-1-mathieu.poirier@linaro.org> <87o8erq0u2.wl-maz@kernel.org>
In-Reply-To: <87o8erq0u2.wl-maz@kernel.org>
From:   Mathieu Poirier <mathieu.poirier@linaro.org>
Date:   Tue, 6 Apr 2021 11:58:07 -0600
Message-ID: <CANLsYkwijvqGv-EdSSC-F727LczXS0gjBbY-YwJ-0OZkKGTZsg@mail.gmail.com>
Subject: Re: [GIT PULL] coresight: Add support for ETE and TRBE
To:     Marc Zyngier <maz@kernel.org>
Cc:     "Suzuki K. Poulose" <suzuki.poulose@arm.com>,
        Anshuman Khandual <anshuman.khandual@arm.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        kvmarm@lists.cs.columbia.edu
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 6 Apr 2021 at 02:22, Marc Zyngier <maz@kernel.org> wrote:
>
> Hi Mathieu,
>
> On Mon, 05 Apr 2021 20:17:57 +0100,
> Mathieu Poirier <mathieu.poirier@linaro.org> wrote:
> >
> > The following changes since commit a354a64d91eec3e0f8ef0eed575b480fd75b999c:
> >
> >   KVM: arm64: Disable guest access to trace filter controls (2021-03-24 17:26:38 +0000)
> >
> > are available in the Git repository at:
> >
> >   git@gitolite.kernel.org:pub/scm/linux/kernel/git/coresight/linux.git next-ETE-TRBE
> >
> > for you to fetch changes up to 7885b4e43231048654c5a80c0a18844ce3185e64:
> >
> >   dts: bindings: Document device tree bindings for Arm TRBE (2021-04-05 11:38:04 -0600)
> >
> > ----------------------------------------------------------------
> > Hi Marc,
> >
> > As previously agreed, here are the changes to support CoreSight
> > ETE and TRBE components submitted here[1].
> >
> > I draw your attention to these:
> >
> > [PATCH v6 05/20] kvm: arm64: Handle access to TRFCR_EL1
> > [PATCH v6 06/20] kvm: arm64: Move SPE availability check to VCPU load
> > [PATCH v6 07/20] arm64: kvm: Enable access to TRBE support for host
> >
> > They are KVM specific and will need an SoB tag.
>
> There seem to be a disconnect here, because it works the other way
> around.
>
> If I pull this, I obviously cannot add anything to the patches that
> are merged (changing stuff would result in changing the commit IDs,
> which is exactly the opposite of what we are trying to achieve).
>
> This isn't a problem, as the act of pulling the branch means that I am
> happy with that, and the git merge makes it traceable.
>
> However, some of the patches (the KVM ones) do not carry your own SoB,
> which is a problem (if you are picking stuff off the list, you need to
> add your own SoB). So for the couple of KVM patches, please add my
>

I wasn't clear on how to handle the KVM patches and as such decided to
proceed conservatively...

>         Acked-by: Marc Zyngier <maz@kernel.org>
>
> together with your SoB, resend the PR and I'll gladly merge it.
>

And I didn't want to SoB those patches because I am not in a position
to cast judgement on them, but with your Ack it changes everything.

> And if you can make sure the subject lines are formatted as:
>
>         "KVM: arm64: Super Duper feature enablement"

No problem.

>
> that'd be absolutely awesome (but that's just me being annoying...).
>

I'll do a respin of this in a couple hours.

> Thanks,
>
>         M.
>
> --
> Without deviation from the norm, progress is not possible.