Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 6 Apr 2021 17:34:39 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Jim Quinlan <jim2101024@gmail.com>
Cc:     linux-pci@vger.kernel.org,
        Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
        Rob Herring <robh@kernel.org>,
        bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" 
        <linux-rpi-kernel@lists.infradead.org>,
        "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 3/6] PCI: brcmstb: Add control of slot0 device voltage
 regulators
Message-ID: <20210406163439.GL6443@sirena.org.uk>
References: <20210401212148.47033-1-jim2101024@gmail.com>
 <20210401212148.47033-4-jim2101024@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="p7S+EREVcBHk3zUG"
Content-Disposition: inline
In-Reply-To: <20210401212148.47033-4-jim2101024@gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--p7S+EREVcBHk3zUG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Apr 01, 2021 at 05:21:43PM -0400, Jim Quinlan wrote:

> +	/* Look for specific pcie regulators in the RC DT node. */
> +	for_each_property_of_node(np, pp) {
> +		for (i = 0; i < ns; i++)
> +			if (strcmp(supplies[i], pp->name) == 0)

This is broken, the driver knows which supplies are expected, the device
can't function without these supplies so the driver should just
unconditionally request them like any other supply.

--p7S+EREVcBHk3zUG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmBsjZ4ACgkQJNaLcl1U
h9Aq4wf/RJ4KoV5Bjz46S5UVDEaAemzgqsSPUMZKuWSEbCnsPFzhpvHj9aqX2CkG
ELR9Fyj9O1r4TKtG3L/RsqiCIJrB6cMBN1n2Ad1Ji5isiZxvzjRJ2trQo/2g3jB5
plVpVy8Ee3qRyfoU6mGu7RrC6vn25wRu0TgMwaf0lge4Wuo9Xi8TGsqmjaIpu5yl
SGpp5RmMScIdmc9WiOsjtFmP89K5j9TMmYc2oRRVTVMaav1x7ghnxtsEIX/ecBuk
QzSIC5GmwS3BhlAns98kRUYr8s9NhuMsVtCuRT3tuNbLGpQxLOxx/9tymh4Qwxeg
PnuEs/O1mzPHMtECWiG8WKiUNlteOA==
=fgu8
-----END PGP SIGNATURE-----

--p7S+EREVcBHk3zUG--