Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp427943pxf; Wed, 7 Apr 2021 03:05:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwI/O9gh4l10DxRpP8n7MjJfnGLOMMY76pn6M7XYeTHtKxNv1WcATFb8nKte0/nPpIaYsqW X-Received: by 2002:a05:6402:3486:: with SMTP id v6mr3370213edc.109.1617789918189; Wed, 07 Apr 2021 03:05:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617789918; cv=none; d=google.com; s=arc-20160816; b=XN6KSuv+X4ib4qyljx+4/6p7CCT6OsKDF1rDQDYGAw5cs3EzZUKnDVCa+i9I3yTKj6 FJG1LTiS+sQLk7mP2GvDyH44bIrJ9ENFvKPhXMXAFVzwJuKoxIUY/pbtR9vcATrq0M/v dPhczStDfsHW94AMk5ndpMqW+rNNusXunoYpbP9fhWRWeaDb9h4Rq8ctgWzyBm5eng39 187wxca2M1yhWzvBRydNd9yk4GD+2JR70XKpCFWLeyCB9Og08ovSe8ECPwdmMYywdkM0 RsCcVB0fCxdD9mgdGDDeNDfITnE1rAUe0JXUlNMtKU2YJeGfbaEAcuQ/TEN19PKjCWAt 6Hxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=dUOVVdYoSYbWJM3R8BfH3yp511tJPXM9SJGSE2TL6GY=; b=Tnn8UrkTCJhTYI2lGfCi1G5Ik+k4C2L/qpaGT/dwg2TQLZPOW96kKGSRGeyu3oQahG mNBEiDDUbAW8vBDiq13X4b3dcUKQpy5wiLbzDtt06pAd/jchTCXdVagJ/iEq4tWg5INI HiOWPlNBf+Us5Wwm5crk5MFPzDXjuW93DO1CSxSJjOAY96kpB1gdFUBjGE6Fw7SzEr0d kst1EeFblU4bwpUiT6qMyuLYqX77OHZXTiW7mp6BhHae/ggoIogY50rmSlu60pGaBURk RSKRpqPiVfG+BhR1Zx/pvKF3x442wvhW1c2kYVloZWkmujX2e90gD9ETs4yRH97caRO9 WTxQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i11si5596852edn.502.2021.04.07.03.04.44; Wed, 07 Apr 2021 03:05:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346625AbhDFQvU (ORCPT + 99 others); Tue, 6 Apr 2021 12:51:20 -0400 Received: from mail-pg1-f173.google.com ([209.85.215.173]:37474 "EHLO mail-pg1-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232755AbhDFQvT (ORCPT ); Tue, 6 Apr 2021 12:51:19 -0400 Received: by mail-pg1-f173.google.com with SMTP id k8so10803139pgf.4; Tue, 06 Apr 2021 09:51:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dUOVVdYoSYbWJM3R8BfH3yp511tJPXM9SJGSE2TL6GY=; b=XzvTLzBSh6AVFmF1bhUcCakBkjYqyiM5hRmbNdk4aaKMQUrWHtM4iNWpHacQCJ3jut nniz2y6tUM3GXo7Qbs/GTppYnltT2AZJz/ZLKKRWGLPLGhRNGiWffXKX0yIWWG622Ak9 7n5CYuHt1TCDBLXL7TIbyVffkbej+qoDPfGL6cLHOVI2gzcNvz2NMjTUg8etMVtWOWkU GKipYQ8nygMkQ62qdAhi/RWoRdXaOY1yjYYZ/9QmAtHNrKZf13ki9oHznkg84thGWA5u 0njk2u6+kHetQeEP7PnC/3yxVvZuoKzpKib6vHXSoeEw5FZWSEwHhYjcj1HB2l3vSl/G L9TA== X-Gm-Message-State: AOAM533o32v/QbiiS3xuqYLlWGbZG3Z29O9XITGjGHubLRO3i799FWS9 zea8kKFYzfSC3UrQBCgWE88= X-Received: by 2002:a63:1303:: with SMTP id i3mr27619155pgl.32.1617727870490; Tue, 06 Apr 2021 09:51:10 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id p11sm3129812pjo.48.2021.04.06.09.51.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 09:51:09 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id AB32F40402; Tue, 6 Apr 2021 16:51:08 +0000 (UTC) Date: Tue, 6 Apr 2021 16:51:08 +0000 From: Luis Chamberlain To: Andy Shevchenko Cc: Michael Ellerman , Joerg Roedel , Wei Liu , Michael Kelley , Mike Rapoport , Corey Minyard , Bjorn Andersson , Mathieu Poirier , Andrew Morton , Tetsuo Handa , Vlastimil Babka , "Paul E. McKenney" , "Steven Rostedt (VMware)" , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, openipmi-developer@lists.sourceforge.net, linux-remoteproc@vger.kernel.org, linux-arch@vger.kernel.org, kexec@lists.infradead.org, rcu@vger.kernel.org, linux-fsdevel@vger.kernel.org, Benjamin Herrenschmidt , Paul Mackerras , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Corey Minyard , Ohad Ben-Cohen , Arnd Bergmann , Eric Biederman , Josh Triplett , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , Kees Cook , Iurii Zaikin Subject: Re: [PATCH v1 1/1] kernel.h: Split out panic and oops helpers Message-ID: <20210406165108.GA4332@42.do-not-panic.com> References: <20210406133158.73700-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210406133158.73700-1-andriy.shevchenko@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 06, 2021 at 04:31:58PM +0300, Andy Shevchenko wrote: > diff --git a/include/linux/panic_notifier.h b/include/linux/panic_notifier.h > new file mode 100644 > index 000000000000..41e32483d7a7 > --- /dev/null > +++ b/include/linux/panic_notifier.h > @@ -0,0 +1,12 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef _LINUX_PANIC_NOTIFIERS_H > +#define _LINUX_PANIC_NOTIFIERS_H > + > +#include > +#include > + > +extern struct atomic_notifier_head panic_notifier_list; > + > +extern bool crash_kexec_post_notifiers; > + > +#endif /* _LINUX_PANIC_NOTIFIERS_H */ Why is it worth it to add another file just for this? Seems like a very small file. Luis