Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 6 Apr 2021 18:38:54 +0100
From:   Phillip Potter <phil@philpotter.co.uk>
To:     Eric Dumazet <eric.dumazet@gmail.com>
Cc:     kuba@kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH] net: tun: set tun->dev->addr_len during TUNSETLINK
 processing
Message-ID: <YGycrv60GeQezQ3Y@equinox>
References: <20210405113555.9419-1-phil@philpotter.co.uk>
 <ba1f5946-d1ef-ee4f-4ce1-15af2b324181@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ba1f5946-d1ef-ee4f-4ce1-15af2b324181@gmail.com>
Precedence: bulk

On Tue, Apr 06, 2021 at 07:26:29PM +0200, Eric Dumazet wrote:
> 
> 
> On 4/5/21 1:35 PM, Phillip Potter wrote:
> > When changing type with TUNSETLINK ioctl command, set tun->dev->addr_len
> > to match the appropriate type, using new tun_get_addr_len utility function
> > which returns appropriate address length for given type. Fixes a
> > KMSAN-found uninit-value bug reported by syzbot at:
> > https://syzkaller.appspot.com/bug?id=0766d38c656abeace60621896d705743aeefed51
> > 
> > Reported-by: syzbot+001516d86dbe88862cec@syzkaller.appspotmail.com
> > Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> > ---
> 
> Please give credits to people who helped.
> 
> You could have :
> 
> Suggested-by: Eric Dumazet <edumazet@google.com>
> 
> Or
> Diagnosed-by: Eric Dumazet <edumazet@google.com>
> 
> Or at least CCed me :/
> 

Dear Eric,

Please accept my apology for this oversight. It certainly wasn't
intentional on my part, and entirely down to inexperience. I will send
the patch again with Diagnosed-by.

Regards,
Phil