Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp443861pxf; Wed, 7 Apr 2021 03:32:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxoOUER77WdyTuDGiGqnRr9jPJoPGxE/4XdqsPvnNzQeFexuEYkIcb7pEDt6Hus8Y0lI194 X-Received: by 2002:a92:d6cb:: with SMTP id z11mr2150652ilp.227.1617791529065; Wed, 07 Apr 2021 03:32:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617791529; cv=none; d=google.com; s=arc-20160816; b=sV2lopRadD5qp+GTBMVJAgShF09dxymdx4vlfsudb+BbwTFueCyBmGuWRTpLi62Ls9 BsXdvNBdf/jxf3t+mejAmRpYQQbggOiNupHnHjuAw2wFTyvzHp/ky5LqgWv4odAYOmy1 A+QfbgZ/++3dqQBBEpOI64yOG3F37eG3FKDk1iID6dxsa7+YH8UqD9/FKYdbqAs4H4vk lelS2kZHBeFvF4os8jLvnKNa98oMgrnlZIbxx8XM1MdRHvNEDxeLJdadM5B5NErFBbaj LswvIIWXiv3S4M3aKvBpitU6ARKaeqGEzyAHK84Kv1wWV96UfnB6YD5/P0g4bU9Cs1Hv HUaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=XUAocMzqslhmkOUnlXNCrYEu99Q+VPwXt4fF/IrMZzk=; b=MuNjJE/ykqFtyVq1Rrcw2iByZDXhTq0DvEEyDRv+firFoNLJEQ/T12fPw2+4STuPuq 0oovr8ASaU9CDR3Q9U3VWD5KXSx7gsAuNOZTc/aA5SyoyNIELC12VtjMWfYJWRoaNNH9 q9D6/MEw+6aaH/R5CByBCXVlECfHvBLXPxeCc7ahkntQEWmLLH1V49FSq7TDAJ8/6Xc6 qBmDh4Q80TvIzP+PBnX52hReqplVTsNgm3rJOX9tmPyjloavHq+gIgwWvjVVFseHtLtp NL5yVO6EMuEhoV+uGQ083FBnj2aeXza/ni6j0654JTi7f/izdppCK0uUSxtnUTjsGmuW 38ag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Gui9PRNa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d18si14843110ios.101.2021.04.07.03.31.57; Wed, 07 Apr 2021 03:32:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Gui9PRNa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347092AbhDFRrq (ORCPT + 99 others); Tue, 6 Apr 2021 13:47:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:32361 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233460AbhDFRrn (ORCPT ); Tue, 6 Apr 2021 13:47:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617731254; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XUAocMzqslhmkOUnlXNCrYEu99Q+VPwXt4fF/IrMZzk=; b=Gui9PRNaQkpTa/n5KCxkmwHwn9M3mKVIJIb6EXTfF9lj87yFYOBIs+S0RaCH77pF9LL73Y SDo5P/tqEAfLIdcf5zXvlHhWWn1dx/E/O8hYDwUFz/ab6JoJsN4LSafVVPU+D56Xuui/Ft w1A9bJahhciuigI9ktEzcf77kd+hYt4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-570-O_U_PLNVPqyZc9UocJRI5w-1; Tue, 06 Apr 2021 13:47:32 -0400 X-MC-Unique: O_U_PLNVPqyZc9UocJRI5w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EE8E4839A42; Tue, 6 Apr 2021 17:47:31 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.40.192.43]) by smtp.corp.redhat.com (Postfix) with SMTP id 2460350A98; Tue, 6 Apr 2021 17:47:30 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Tue, 6 Apr 2021 19:47:31 +0200 (CEST) Date: Tue, 6 Apr 2021 19:47:30 +0200 From: Oleg Nesterov To: Jens Axboe Cc: LKML Subject: Re: [PATCH] task_work: add helper for more targeted task_work canceling Message-ID: <20210406174729.GC13270@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/04, Jens Axboe wrote: > > +struct callback_head *task_work_cancel_match(struct task_struct *task, > + bool (*match)(struct callback_head *, void *data), void *data); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Feel free to ignore, but how about "typedef task_work_match_t" ? Either way, Reviewed-by: Oleg Nesterov