Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp496250pxf;
        Wed, 7 Apr 2021 04:57:16 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJx7OlX4zq5PTeUdovvOUfqv3H5gjP188rjnRDVmE0b+Tts/fUZ/iaViDfGjyDiGmzctHuBi
X-Received: by 2002:a02:c8ce:: with SMTP id q14mr3107889jao.135.1617796636008;
        Wed, 07 Apr 2021 04:57:16 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1617796636; cv=none;
        d=google.com; s=arc-20160816;
        b=ANzGaS3jZgCVs+MZh/DGLDAdZ7pALRVpJ9pqf3TbTaW8/3St+OSJ4gBno8S2XhDVnX
         Z2RUHfEgv9e++7/bbPiOCX+eiwYKirsR45ctm5ATR5jldSdcgVK+9GfJTmHMJ0ld/qKT
         nS8RRW5zb9fNuQ0VkmYLyDmV6WNNqQduLfKozEeBt1xvk8NaXn3yfn2stwI0PVSjGrYV
         ahDg62Z+D6fQA4t2/YvUsUEV9JGguDsTHjNobyc90rwUYFj2MYvyC/HHgs2bzdqjljSq
         +kTd0e06PtIg3KqeSSwP7cZPorArjDx9hh19PxAGxg+DjAkOgO2M297A6YHsO33vv18N
         FbVQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=aUuldTyb8qi6MuaJQVRTIzsu3Yu7G1Zl6323EH2Rljo=;
        b=aKoGiMItJF9fjIjHf3/wHHpSnseBY6csoLsDH3qT0a2t/NtCtHZTvcYpsT9oPk/9mU
         pNjVRa2ZCZOSEGOsflbPPWuJQ14cEU5uuKm8Z/PLeUyDJAjTF55QpdAkPiDXMGJMIhzt
         su9RxRjRY7zN2GV7nEhFjudlXYkC35o4Hp5chm953iBg3dbWsKuSAOWzn69xxgjlrBYN
         O/vOyedEjRXd/rzfBrtPM9Pd0MSZXqC49zp31Q5EjbJ4XVPVd7lNZ07bjLn6V6AJxlAd
         Vn/nvLaEePGvbDOJ+UbRZ4ukFIQfTXWo3NolYwGGrIEtpxHv5L8hAP/UqMgeNiCxdDCI
         KcDQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Mf9jFgg1;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id n5si19938378iob.85.2021.04.07.04.57.03;
        Wed, 07 Apr 2021 04:57:15 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Mf9jFgg1;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S237884AbhDFSy6 (ORCPT <rfc822;linuxmindflow@gmail.com>
        + 99 others); Tue, 6 Apr 2021 14:54:58 -0400
Received: from mail.kernel.org ([198.145.29.99]:50770 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S240567AbhDFSyL (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 6 Apr 2021 14:54:11 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id 1F02E6128A;
        Tue,  6 Apr 2021 18:54:03 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1617735243;
        bh=gTXBArHDHmSIeLqmt58KO+JpgBcYSDf6+tvFLMK/JG8=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=Mf9jFgg1SqyGJSd8CYMR7SSSN9tfSHyyyak6obmSwKkS9v53LOrFZOjIQZYHpRBen
         IUHGSrRYfZIXV1erYDHJaXX6xn+FnSUQbk/mBYe+ncoYZspwKEMPMU3uK3xWUecGkQ
         5hfYWo+mebzIJxK6J2clr9bTBlZ54qv2WPSgF3KdGGOdiSI+X71xhC6ZcI80fBmwip
         d5pKfxpb/qrIb7HKvKAIuAUFUm7znvjh3uBf35WNEX0E/2yNXOfkkLePV6VyPGb7uB
         T8bSFMxlAs6PK7BYY80GRuBbLDbXhRffHUNH4EFUfRYyuUHLYVI2iKuSk86o4NO1mL
         jDBkfmsOoh78A==
Date:   Tue, 6 Apr 2021 11:54:02 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Wong Vee Khee <vee.khee.wong@linux.intel.com>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Michal Kubecek <mkubecek@suse.cz>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net v1 1/1] ethtool: fix incorrect datatype in set_eee
 ops
Message-ID: <20210406115402.373ba332@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20210406131730.25404-1-vee.khee.wong@linux.intel.com>
References: <20210406131730.25404-1-vee.khee.wong@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue,  6 Apr 2021 21:17:30 +0800 Wong Vee Khee wrote:
> The member 'tx_lpi_timer' is defined with __u32 datatype in the ethtool
> header file. Hence, we should use ethnl_update_u32() in set_eee ops.
> 
> Fixes: fd77be7bd43c ("ethtool: set EEE settings with EEE_SET request")
> Cc: <stable@vger.kernel.org> # 5.10.x
> Cc: Michal Kubecek <mkubecek@suse.cz>
> Signed-off-by: Wong Vee Khee <vee.khee.wong@linux.intel.com>

Reviewed-by: Jakub Kicinski <kuba@kernel.org>