Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 6 Apr 2021 17:11:26 -0400
From:   Eric Whitney <enwlinux@gmail.com>
To:     Pavel Machek <pavel@ucw.cz>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Eric Whitney <enwlinux@gmail.com>,
        Theodore Tso <tytso@mit.edu>, Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 5.10 004/126] ext4: shrink race window in
 ext4_should_retry_alloc()
Message-ID: <20210406211126.GA14411@localhost.localdomain>
References: <20210405085031.040238881@linuxfoundation.org>
 <20210405085031.189492366@linuxfoundation.org>
 <20210405152908.GA32232@amd>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210405152908.GA32232@amd>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

* Pavel Machek <pavel@ucw.cz>:
> Hi!
> 
> > From: Eric Whitney <enwlinux@gmail.com>
> 
> > A per filesystem percpu counter exported via sysfs is added to allow
> > users or developers to track the number of times the retry limit is
> > exceeded without resorting to debugging methods.  This should provide
> > some insight into worst case retry behavior.
> 
> This adds new counter exported via sysfs, but no documentation of that
> counter...
> 
> Best regards,
> 								Pavel
> 

Thanks for the observation.  I'll check with Ted to see what he'd like.

Eric


> > @@ -257,6 +259,7 @@ static struct attribute *ext4_attrs[] = {
> >  	ATTR_LIST(session_write_kbytes),
> >  	ATTR_LIST(lifetime_write_kbytes),
> >  	ATTR_LIST(reserved_clusters),
> > +	ATTR_LIST(sra_exceeded_retry_limit),
> >  	ATTR_LIST(inode_readahead_blks),
> >  	ATTR_LIST(inode_goal),
> >  	ATTR_LIST(mb_stats),
> 
> -- 
> http://www.livejournal.com/~pavelmachek