Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp605377pxf; Wed, 7 Apr 2021 07:26:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx1tPF4V8DhErwavGBqVEILp/NivEF8C5majM90H7SY8+Bw8EZPEShS9qrhB5t3my7Bhgb1 X-Received: by 2002:a17:906:154f:: with SMTP id c15mr4046559ejd.142.1617805604620; Wed, 07 Apr 2021 07:26:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617805604; cv=none; d=google.com; s=arc-20160816; b=xPPjPBrieY5SjzBQDQCJjphJrbMXKhm815+Mty83xcabnxddwJ4pMw3+UDZHNqMvgQ 0YbWDjrISfPHLbWQn55nIvOKesVNMt8kGyry2od9PEFHHBys7U0a92Iu/gR0DmvCW7pj t/+vF3VN2+Wsa45UoNDJlLmJawXjWIvr6GNdfbj50h3PdVg+DJJs+ii6QDrryo8F/Hhe WikN/43R5yGnjvmsEN0sb91dhyodPfvh61qM688W1oPc4iRgAOtG79/T1q5QlSBW3Viv T+8uUZl681HsPhz9woZvMzKO365Km1IRgErVP/0fUsFGrTr85+1x3DKix7Km8Bp9ps5f Zo8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=EYLDIVy5Lq+tCCcmxS9wSWSpPH1DV1dAdlXfneGhR7w=; b=bKmTNOq0TZqAyb9z0exwulT6b8/Um2XlhwAAX7kgX0me/+zCRZun99ksyHR7skBnH8 CjgBifClnrAD9fGhFPFvPAO1XyDZ60hR8ZCTpfI0M6D5aOV4eVGHu2No8MbSZF9cMww+ dxPJelqDEXoAi+KvaJBQJxKHJk9eOpXQmLXPHz894x3xMhbL2SnURPzLk8TOlquf4iiO sOwuhXKOO6SnKWaq3Om4FeaNYQR4Xw8wQvpWFQ5rVcM8gWWaFEQG1mQNwxkPtS+ytcPD 3uTSL6CfUyqNkFalGpzNuooCZVu6b5fChUebj86p04LsxCPfYEhraxSvCEhJJsnvO2c6 92ZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@126.com header.s=s110527 header.b=SPFZZtkE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=126.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id da2si7970377edb.506.2021.04.07.07.26.19; Wed, 07 Apr 2021 07:26:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@126.com header.s=s110527 header.b=SPFZZtkE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=126.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348429AbhDGDrA (ORCPT + 99 others); Tue, 6 Apr 2021 23:47:00 -0400 Received: from m15113.mail.126.com ([220.181.15.113]:36907 "EHLO m15113.mail.126.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344405AbhDGDq7 (ORCPT ); Tue, 6 Apr 2021 23:46:59 -0400 X-Greylist: delayed 1997 seconds by postgrey-1.27 at vger.kernel.org; Tue, 06 Apr 2021 23:46:58 EDT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id; bh=EYLDIVy5Lq+tCCcmxS 9wSWSpPH1DV1dAdlXfneGhR7w=; b=SPFZZtkE7t/KQmLEIBEGSzC7QSWAYnUt+q dJXipiD05wCV/Jdog3/D7te4YJs/PTjZ2b/vSlR1jfNvYM/ZA4+TimnfMyt7r+vk WDXFuIsVLbs7t0W9EpZ1q+ARzkteO2adkMHyoKBG0rEtkFP2Qw23TgxBlWJukXoi UfJY08/2U= Received: from localhost.localdomain (unknown [106.16.165.72]) by smtp3 (Coremail) with SMTP id DcmowAAHDeGnIm1gdK2IQA--.41702S2; Wed, 07 Apr 2021 11:10:44 +0800 (CST) From: wangyingjie55@126.com To: alexander.deucher@amd.com, christian.koenig@amd.com, airlied@linux.ie, daniel@ffwll.ch, airlied@redhat.com Cc: wangyingjie55@126.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v1] drm/radeon: Fix a missing check bug in radeon_dp_mst_detect() Date: Tue, 6 Apr 2021 20:10:04 -0700 Message-Id: <1617765004-5308-1-git-send-email-wangyingjie55@126.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: DcmowAAHDeGnIm1gdK2IQA--.41702S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrurW8KF4kZrWftr1xKrW3ZFb_yoWkGwbE9r n7Wa4rJayDKryIq3W7Z3WxX3sFgw4j9F1UWr1ftryIqry8Jr1fuF15t3WFyan8Xay7Jrn8 K3WrKFy3Ars3KjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUU9XoDUUUUU== X-Originating-IP: [106.16.165.72] X-CM-SenderInfo: 5zdqw5xlqjyxrhvvqiyswou0bp/1tbiVxRtp1pEDOzDMAAAsE Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yingjie Wang In radeon_dp_mst_detect(), We should check whether or not @connector has been unregistered from userspace. If the connector is unregistered, we should return disconnected status. Fixes: 9843ead08f18 ("drm/radeon: add DisplayPort MST support (v2)") Signed-off-by: Yingjie Wang --- drivers/gpu/drm/radeon/radeon_dp_mst.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/radeon/radeon_dp_mst.c b/drivers/gpu/drm/radeon/radeon_dp_mst.c index 2c32186c4acd..4e4c937c36c6 100644 --- a/drivers/gpu/drm/radeon/radeon_dp_mst.c +++ b/drivers/gpu/drm/radeon/radeon_dp_mst.c @@ -242,6 +242,9 @@ radeon_dp_mst_detect(struct drm_connector *connector, to_radeon_connector(connector); struct radeon_connector *master = radeon_connector->mst_port; + if (drm_connector_is_unregistered(connector)) + return connector_status_disconnected; + return drm_dp_mst_detect_port(connector, ctx, &master->mst_mgr, radeon_connector->port); } -- 2.7.4