Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] tty: n_gsm: use DEFINE_SPINLOCK() for spinlock
To:     Huang Guobin <huangguobin4@huawei.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
References: <1617710163-48158-1-git-send-email-huangguobin4@huawei.com>
From:   Jiri Slaby <jirislaby@kernel.org>
Message-ID: <d6776a2e-15da-162d-5732-364dfda0a3b6@kernel.org>
Date:   Wed, 7 Apr 2021 07:23:16 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <1617710163-48158-1-git-send-email-huangguobin4@huawei.com>
Content-Type: text/plain; charset=iso-8859-2; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 06. 04. 21, 13:56, Huang Guobin wrote:
> From: Guobin Huang <huangguobin4@huawei.com>
> 
> spinlock can be initialized automatically with DEFINE_SPINLOCK()
> rather than explicitly calling spin_lock_init().
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Guobin Huang <huangguobin4@huawei.com>

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

> ---
>   drivers/tty/n_gsm.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
> index 9e12f9cb1a98..d60cffc70a0c 100644
> --- a/drivers/tty/n_gsm.c
> +++ b/drivers/tty/n_gsm.c
> @@ -266,7 +266,7 @@ struct gsm_mux {
>   
>   #define MAX_MUX		4			/* 256 minors */
>   static struct gsm_mux *gsm_mux[MAX_MUX];	/* GSM muxes */
> -static spinlock_t gsm_mux_lock;
> +static DEFINE_SPINLOCK(gsm_mux_lock);
>   
>   static struct tty_driver *gsm_tty_driver;
>   
> @@ -3257,8 +3257,6 @@ static int __init gsm_init(void)
>   	gsm_tty_driver->init_termios.c_lflag &= ~ECHO;
>   	tty_set_operations(gsm_tty_driver, &gsmtty_ops);
>   
> -	spin_lock_init(&gsm_mux_lock);
> -
>   	if (tty_register_driver(gsm_tty_driver)) {
>   		put_tty_driver(gsm_tty_driver);
>   		tty_unregister_ldisc(N_GSM0710);
> 


-- 
js