Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp864914pxf; Wed, 7 Apr 2021 13:37:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw2GexKsACwnuVY1K6Fmllk5ozbbnaRgyxzp3B28EjuvPTt54O3w+Canoa92EwmXVbU7i95 X-Received: by 2002:a17:906:3882:: with SMTP id q2mr5943090ejd.540.1617827864589; Wed, 07 Apr 2021 13:37:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617827864; cv=none; d=google.com; s=arc-20160816; b=NOHhker78PnGsSHi8PF7d0XfNnsBftX2/tMG7US4ZD8r59rVfGjU2/NBmbNQA0yU4O aYqdShQvSspRRbNlep9oiJjQu2ivjdmUHXFWJHOnMm8LcEgcMhYMiEBHK37nFJzNmjm6 PzfIY6rrGZA79mKrDDACLv4crVSZAhDh0DmCb8r2hf1gTvez04ATcTsTT6FDyqKTmz/9 EoRCJnnDj5lUlGZLS9y3kYSGYLTqXCnFH/0+O1xdpRXdlPq9HAx7ZdRhP1HHz2AANxQq fH9qxxrJudpxvUftTLVHtwKyGMtwRAhdz8S0SIx3Cnjm8CJ9Wpro1DLKS/qZPs04CGKJ hWmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=vRPC5V11nqJsZb7mB03bJAmu3Bn6LF/Kt0OlXupRglc=; b=Z6YTSMzhdud7KoAxicyMQrAdvfpDferHlD5CagS+hRnT7i28UYpah8WgP/N2F4+Txe uJ4pSKr4FRKR1vKpNnBhin/k3lmW7QVXdGY+oXR+Bu5XyBw68iXrN9UbKOepXPjNL3uO ZxU7Bg0xYcG4itFSsT6JiPC0LTiNfHcZaYi0vZQDb1JIQiTi9P9QabY/b7vCjcyYhDK5 fmgOfRYYzK4Riw/AHGQwLoLxSLdI826Jmg2uShMSGtSznSV2eokCokzrcTxM6mZnq3ZR Ry4i+z7g66id5GkrPZSLeDJ7qEj4VO3sDjb7CYkk+cdei03LsXjlzb7gD4VuxXbqxh4e CyBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=u+xv4he5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w3si13098928edx.268.2021.04.07.13.37.21; Wed, 07 Apr 2021 13:37:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=u+xv4he5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245202AbhDGIfL (ORCPT + 99 others); Wed, 7 Apr 2021 04:35:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:56302 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234223AbhDGIfK (ORCPT ); Wed, 7 Apr 2021 04:35:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A596061363; Wed, 7 Apr 2021 08:35:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617784501; bh=QUPSZJEVZ4gOqekzobUa4Tu78f4ebblB6ELbnwdOIw0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u+xv4he5FiLWTw6uVqlGVRKzfN4vnXj8XwhEQEZGLONO/36pm0CpWha2XbchjGEVB /oo+0uryitIsJhls/71V1ZITjEZm54YgUFkhP+AtzkQYxRw80bSsFQC8Hkg9Ty2Q4Y TA0yr56OIxQtLXx57eX1ficLY5bBCUGBEcWGQtr4= Date: Wed, 7 Apr 2021 10:34:58 +0200 From: Greg KH To: Beatriz Martins de Carvalho Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [RESEND PATCH] staging: emxx_udc: Ending line with argument Message-ID: References: <20210406193409.96428-1-martinsdecarvalhobeatriz@gmail.com> <4c7df741-4e73-2ac4-f0d8-c9513ae29c88@gmail.com> <4d7ebe9c-8ebc-2fc9-10ed-6756ab42d5d7@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4d7ebe9c-8ebc-2fc9-10ed-6756ab42d5d7@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 07, 2021 at 09:16:44AM +0100, Beatriz Martins de Carvalho wrote: > > Em 07/04/21 06:37, Greg KH escreveu: > > On Tue, Apr 06, 2021 at 09:00:07PM +0100, Beatriz Martins de Carvalho wrote: > > > Em 06/04/21 20:36, Greg KH escreveu: > > > > On Tue, Apr 06, 2021 at 08:34:09PM +0100, Beatriz Martins de Carvalho wrote: > > > > > Cleans up check of "Lines should not end with a '('" > > > > > with argument present in next line in file emxx_udc.c > > > > > > > > > > Signed-off-by: Beatriz Martins de Carvalho > > > > > --- > > > > > drivers/staging/emxx_udc/emxx_udc.c | 11 ++++------- > > > > > 1 file changed, 4 insertions(+), 7 deletions(-) > > > > Why is this a [RESEND] ? > > > > > > > > What happened to the first version? > > > Sorry, I didn't receive your review, and in kernelnewbies tutorial, they say > > > if not receive a response, may have missed the patch, so I resent it. > > Do you have a pointer to your previous patch in the lore.kernel.org > > archives anywhere? I can't seem to find it. > > > I found this, it's what is you need? > > https://lore.kernel.org/linux-staging/20210401195457.24512-1-martinsdecarvalhobeatriz@gmail.com/ Ah, yes, I saw Julia's review and assumed you would fix up your patch based on her comments. Please do not ignore review comments, it makes everyone's lives harder. thanks, greg k-h