Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp869036pxf; Wed, 7 Apr 2021 13:44:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx8cSqnQ6qiapJ/JUCndyQvE0FXfyXrnxU4pZi8pgP8jPxWsxCmb/4kw8oMut91wkKLL0c8 X-Received: by 2002:a05:6402:512:: with SMTP id m18mr6703414edv.372.1617828284316; Wed, 07 Apr 2021 13:44:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617828284; cv=none; d=google.com; s=arc-20160816; b=ONAtgNXHGv228Al7V6R7GO6uC+2qbATAga9aIWmyXykHxZARRAhJi9bFF+cTB3sQ0y dX4zluvPLPQiaZXkDIeLfzJoNzM9HB8eZj/Bjl8Fo38c1F6XYYb/mfpD5vv5vrcZi5aF EqkXbGDN85BCExDzRtXYXi6GwNLePnGkiSAIznuVellWoTxiaJQH2W/2PiWGX8WBAqLF 9YY7DUXMI5wSPcisSP3/79ZRki6PmQsHFfvjdHX1w7yzn9dG5fTC5IGgIuIidhjsbVcY u13crvPWY2ql0nbjDb9CC3M3+dVeh6x5JMIItmG/mJ8vHRoSr7PBl5E24/z1lPmpqb2g 6hHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ezue5kDeqE0ZtSRkrpYBHuexgmqA31YZEyH6lvl25uw=; b=b7OfUUWR12eFlJMMLfqrpmaxvzvBHZBUfpcarJtdsEuNZfu+7+IhxgfxQn5z6ShUAe elRx4hBuBQUQQObkEGwMgXsi74U9k3yMXRwa2fWjSA0z8EUNOItYwHhY+PJt6SS7qWCH S5APqNVC39/oIOyAeSaCa4hKZmD8DoU2Bp2pxMODpvIMKnjxtuqQoglImPIr3ByHckps Ofo+S74RMDkfuHhg4H7lkp4lwirmWl8hqqD2rv/rWxy7nvVmwEsla8BXmlsm632+aTaP uPNuAffFUkf5Qy0NQvWuNUqmOKPsNdHLhkHDz/zwFH1oh36qVzuDTp9gPrnGQFLDQ7U7 v1Sg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fqfNmPZO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n19si12582781ejz.550.2021.04.07.13.44.21; Wed, 07 Apr 2021 13:44:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fqfNmPZO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350440AbhDGKAE (ORCPT + 99 others); Wed, 7 Apr 2021 06:00:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230220AbhDGKAD (ORCPT ); Wed, 7 Apr 2021 06:00:03 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A44E5C061756 for ; Wed, 7 Apr 2021 02:59:53 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id r9so4126000ejj.3 for ; Wed, 07 Apr 2021 02:59:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=ezue5kDeqE0ZtSRkrpYBHuexgmqA31YZEyH6lvl25uw=; b=fqfNmPZOVFQDe2AouClgXbDOgSSjo7aUUzPL781A9s2Jo33q0bvg/DD2MWEg4KaSZa 8ilpB1fN+fA6nmCjXOacIkmkTFzYJpZ0oE34PfRR6j/VEz0AgyZ0N7fA+g0bZGLhvc/9 PIsvPn50bde8jK6T7XTX077ZjrGW6TbIJDZ98NhLNQBkSNpgyDsgvpHRzzuBeqDCHMOu gTuneOPxP7SVUdIZGbhSnEFWEE9mc4smi+GEqVlXS/qxF++tQqBMgUu2i1L4FR87ch14 /LaZ/Pw5cRuPugRjt0fPwBb7UERuctoxNsthuIPj7uVccqM8L0QwpQHnG/+ZemVvs+gU tpSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=ezue5kDeqE0ZtSRkrpYBHuexgmqA31YZEyH6lvl25uw=; b=qP3yT5whDSycaFq1QZT+81SP5OaumFQqU6tSCmKH+hj0+LuXewrqHzHwiFw7jFVtHg uIhX6nzDCzBQMUkYD4GhEfgMdjwiNLqcMXJz2GBq7q7f1NCq9L+JPXIUjM1rPisNbxl4 VpCMatmPUFRNigZ59I1LCE5vvDASzT59Ct1UgznpRwvtkOT//E+QExbQv35qwr8EYml3 83IcwzTdpEn9207GT5o7WgzWrcLHLDEeWbt2Sql2Ck5MyN7R6RjBxmI7v43P36GuHYtN YLXmL/Q15+BWpw933tUsx6/99WALCi1+vMUW+COGQk0gHJo3DXDk4kV43pdOJYjeisaj 411w== X-Gm-Message-State: AOAM531YPOUFYP0D9qFyhEkLCvk+ATJNk6I8Zx1sQNzE8y2RlazLLIeD L/WTRphF0JYmay99XvxcaSXqZw== X-Received: by 2002:a17:906:fcaa:: with SMTP id qw10mr1370992ejb.9.1617789592378; Wed, 07 Apr 2021 02:59:52 -0700 (PDT) Received: from dell ([91.110.221.225]) by smtp.gmail.com with ESMTPSA id e5sm7521056edr.64.2021.04.07.02.59.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Apr 2021 02:59:51 -0700 (PDT) Date: Wed, 7 Apr 2021 10:59:50 +0100 From: Lee Jones To: Dinghao Liu Cc: kjlu@umn.edu, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: arizona: Fix rumtime PM imbalance on error Message-ID: <20210407095950.GA2961413@dell> References: <20210407051149.31422-1-dinghao.liu@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210407051149.31422-1-dinghao.liu@zju.edu.cn> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 07 Apr 2021, Dinghao Liu wrote: > pm_runtime_get_sync() will increase the rumtime PM counter > even it returns an error. Thus a pairing decrement is needed > to prevent refcount leak. Fix this by replacing this API with > pm_runtime_resume_and_get(), which will not change the runtime > PM counter on error. > > Signed-off-by: Dinghao Liu > --- > drivers/mfd/arizona-irq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog