Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 7 Apr 2021 08:34:36 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>
Cc:     Christoph Hellwig <hch@lst.de>, Joerg Roedel <joro@8bytes.org>,
        David Woodhouse <dwmw2@infradead.org>,
        Alex Williamson <alex.williamson@redhat.com>,
        Kirti Wankhede <kwankhede@nvidia.com>, ashok.raj@intel.com,
        sanjay.k.kumar@intel.com, jacob.jun.pan@intel.com,
        kevin.tian@intel.com,
        Jean-Philippe Brucker <jean-philippe.brucker@arm.com>,
        yi.l.liu@intel.com, yi.y.sun@intel.com, peterx@redhat.com,
        tiwei.bie@intel.com, xin.zeng@intel.com,
        iommu@lists.linux-foundation.org, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Jacob Pan <jacob.jun.pan@linux.intel.com>
Subject: Re: [PATCH v8 7/9] vfio/mdev: Add iommu related member in mdev_device
Message-ID: <20210407113436.GD7405@nvidia.com>
References: <20190325013036.18400-1-baolu.lu@linux.intel.com>
 <20190325013036.18400-8-baolu.lu@linux.intel.com>
 <20210406200030.GA425310@nvidia.com>
 <1cbe97fb-5595-8cf5-9e0c-1a2edf8c5d9a@linux.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1cbe97fb-5595-8cf5-9e0c-1a2edf8c5d9a@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from mlx.ziepe.ca (142.162.115.133) by BLAPR03CA0061.namprd03.prod.outlook.com (2603:10b6:208:329::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17 via Frontend Transport; Wed, 7 Apr 2021 11:34:37 +0000
Received: from jgg by mlx with local (Exim 4.94)        (envelope-from <jgg@nvidia.com>)        id 1lU6SC-001zjj-8v; Wed, 07 Apr 2021 08:34:36 -0300
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 817c05ba-8fe0-43c8-00f4-08d8f9b92026
X-MS-TrafficTypeDiagnostic: DM5PR12MB1339:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM5PR12MB1339D4A85AC920E9579B1052C2759@DM5PR12MB1339.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2449;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 5CrrcKOkFD7TewxUs9YE9kMREI+olBm04yYyGxL1lhBZYJcIh1aPzRkVKDC3RNNExCVvI7UdMHCoQNC5FVjY6MZwYmknQtFRj7rgM/WklBkHIlqUeVgMPdsF8/g4FG1BU2EZ99RQaQPj4ch+pPBp/7R4oOyIBgkFLWP/AVOCU5hCPthJreJDWS7u+n5YhWBZOS61rsPNp17+Y8Tr+BkKjDv1SjIUshtGpsV+MlpbcW2g9/2J6anVVlBuRBJtN5RnSVXIotttxOWeRPLuOh+zB/OtvuuHxFK/iozdEQ665NZNYrt2uBooH8NQjfigQ7lKjVMFgvkLAT3OvLSO4XdMPn788VOCeIYVLKsfta4znYkDSPXM06IAGh8fK8UF67WDdRn1N6UBUKkyFy5Mu2gbsNwsaRB5JnYTRpeT6A71zd3Rb+0Efm73JdvYXDSVdhnuPS+JOBPBidJpDqkVArE0fO8gQbfdC2026P8puYzfnGRwIcX4kT/0w0jfGJ9bV10zyQXvh64XF9+9Mpy9kpQokWWx9GBPDmPNU3kf8skIs4qMorUM7RnqLBbSfgjf16YQ21pTq7KmKPz278BLeomiRoPgP5yfAyTnJPqqXyK37sKFD4+7aqw77MjKQ3i04X76qmy3kpn4co84SGd/qrNwBctrBPOON3CAWNYHvs1yBSGaXjVIuquxJKqoUwlSkeP7KEYyx56Q3SCeRwGAOk//zGekj7LiNEduTqA581rgofW3i6kdiCoVqFxF+ZskNA18
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB3834.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(136003)(396003)(376002)(39860400002)(33656002)(426003)(2616005)(7416002)(86362001)(2906002)(66946007)(8936002)(38100700001)(966005)(66476007)(26005)(186003)(66556008)(9786002)(8676002)(5660300002)(1076003)(54906003)(478600001)(4744005)(6916009)(316002)(9746002)(4326008)(36756003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?+kY+NIFRyas285mA+wO2KmJcEZ7yGWL4+pYKi39x5g+GLAC2zlgG0IzO7c1p?=
 =?us-ascii?Q?CjUHDjxnZywWaMuJuM8KvUWW9ESo6ZhV3fqoXsCEqWkVsFUWy6mplysnJUJq?=
 =?us-ascii?Q?EcVAEn+Xi09YkVzWRzMVZQ7lgTb4F2B/HUR1CJkrzxL+T+Sm5LdS1JXJcBaU?=
 =?us-ascii?Q?5JMStS9BfPIzxYXWAIkN8bYw6VOBe3IYy//GwhktZQcw5G7tcoM7/VX1pAlb?=
 =?us-ascii?Q?0mPld9OXd2AF8FpOVulm1FgMw90EjeWButtpZaqMIrSUDAOWxcAmor3GViAu?=
 =?us-ascii?Q?KwuXJAP8nCkhKIy09fO5KN4qeackrnblDQBapDrMItqUVcM6W0P3rfsarBF1?=
 =?us-ascii?Q?nQ5nHhMZ/cwFJdkMCQEraOmBjDwHVYwkBa+ZF3ZLd3aZaKj/bAYETTfhkOE8?=
 =?us-ascii?Q?j1e71Kem6Yu9VirP6b9bQChVzmDbQhYiw79Pd/0dZey1f0nRCUtnNiMXbNZk?=
 =?us-ascii?Q?yG773pZSrOB4CbPofADB2FjGQuQChdwg2uaCyiTg4LZQrPJYz02AwPI3NXkX?=
 =?us-ascii?Q?1VqnnnqjgYcgD+fLOMoUpu1cdHfGdZk7MKXlyWfy76u+1+G65xj7vWdMhpyo?=
 =?us-ascii?Q?+Y7/LFv8gqkMV/txeEt0BSrAahakReFmG3Gx+tP/rP3HJfZ8/S2EIEOG9WAv?=
 =?us-ascii?Q?3eFDqFNZkLCDIo4QwTFfxpjkWOxJQfbv47BrFSgRzq7xbrZsHTNKEXh6tHYH?=
 =?us-ascii?Q?JGZMP6D++HlVbLXlU2M80ZMa4m9UaUZhAKr6ut0Qw1yKFACvvkS+RWLOp0ha?=
 =?us-ascii?Q?tsmt6fAtRpOf3ZzrKaTiFceAyyLHRSIus9w5QMLRzOwwOU8j+6UJq5X8jnUN?=
 =?us-ascii?Q?7FpczQN7X3RO0RMiyu1aLJ2KRtQbn4bs1ymgti2AvtGWAbV8VTORkc3GMb9/?=
 =?us-ascii?Q?Ed71chD3y97DQy/PUIKwGzWJF8uO+StuwaFpQ4RjIJpHvLBv+CRpwhD8RmrJ?=
 =?us-ascii?Q?S21pKNFft4yIzFtgcnLFig7VOfsZypjFnQGPX/8ILVulpkiapfa1prDuCSni?=
 =?us-ascii?Q?koFXWNO9OUMyn6qO3ARKeZh5xdm8qH50ghqmXUCGJvj3ZngYvf2UchZmc7J9?=
 =?us-ascii?Q?vvQNBXSABCb9mtenDgoWuzKOgynEckx8xsfjw9VLvZwf+nQHOfvvj7Cw6B5+?=
 =?us-ascii?Q?qBy+edC21vL+fQ0DH7TDBOpbB5/VVqpswAH9cNCdvsytd6KO3D8+vl2GAZEW?=
 =?us-ascii?Q?ac4abPniQ+gZtAoYGesJx7DC9Qr2lqZnfIqa2mYerD5YpW1xUuoj3bersRKO?=
 =?us-ascii?Q?B2B7mFapgOsCOrzaMkB6m0lWiO7VpTzjr8llsnCdj0DLsD0b+WEmB4gW6AWa?=
 =?us-ascii?Q?K3bcRSDQhMeh4XkMnck6n0xW8CO1ycvWEFkDP8vyAdQdgw=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 817c05ba-8fe0-43c8-00f4-08d8f9b92026
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3834.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2021 11:34:37.9690
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vRmIyPBbLyHWEW4YLbgUhxDs3jpN0KS+vjIjb3Bv50vjNllQqvpPdBg6SJF33NE7
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1339
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Apr 07, 2021 at 09:58:05AM +0800, Lu Baolu wrote:

> I've ever tried to implement a bus iommu_ops for mdev devices.
> 
> https://lore.kernel.org/lkml/20201030045809.957927-1-baolu.lu@linux.intel.com/
> 
> Any comments?

You still have the symbol_get, so something continues to be wrong with
that series:

+	mdev_bus = symbol_get(mdev_bus_type);
+	if (mdev_bus) {
+		if (bus == mdev_bus && !iommu_present(bus)) {
+			symbol_put(mdev_bus_type);

Jason