Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp876052pxf; Wed, 7 Apr 2021 13:55:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw0244ekokLL+gKs/q8Q8GWIlIG7YCIBphBZ1ntfgEYzEg85QJEzf495xoYJi9/cnld6KX2 X-Received: by 2002:a05:6638:3a8:: with SMTP id z8mr5418731jap.111.1617828913643; Wed, 07 Apr 2021 13:55:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617828913; cv=none; d=google.com; s=arc-20160816; b=ji/lAue5Vpha0gPmQel0dBKzDwTP8gx4vsc79PfsuyvdNqKraZ34xDCmMnVRAlmNb6 X7kg7JFNeVPCNCqnveN+8ioUWj3mN1RWy90A+0xk6CS6mtCQ2biot9FnwmzZPi5iCLG9 IPt8rGI9kk8dDXC9NTvFAZR7eiMLdT3H4KqmmbKsC8rTfDXjjg9esxkv6c46rPIFS5AX cGvqs1TxkCPfGe6WpOqtXCBvkKB9B8/9QvV1I1Xblfd3qB1YumA2ed7qRaLM5FdPDUBS /mUFHtIhvIPzNUi0zCKiKaXk90VRclFCHAl9vYuhQ1IFmPm4XlT3rjgHD3XCJVOW/YYv 4b9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dmarc-filter:sender :dkim-signature; bh=BlfJ7ChYdm5fsjVC9Gacn3nxjSF5AqDGwGm8a4pwp7c=; b=gBAN1msTDY5dVx/vTS19T4EZiIw9tKqqc+256KI2JSeSbN2puV0i8qyScT0tqUB5e+ oUPrBRabfKJPzRepJ0sMEry1j0i+W0CkjpbnxMDejmy10NOm/vvn5m+RXLH/F3vs3M9r aMGVOI+YPU7ccyAbyCIFYH20Sih1CEBHsiKBznsvOHY/5e/mquxbzmc5dlIdcjOV8Tu0 vtdsr3mXVqbNP13vq7+o+kcqdAP7fa9zLU+GUoGfSuU4tQUVVsoDwzhceXaox2pAs7L7 hAsFY3VelcbxAyaTFWgXwFgwZUuwe3YRE/cZw8iMaRUQENMLeRgfVXnsxgEKp8qRGkCt jLCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=HatXvphb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h13si727073iow.73.2021.04.07.13.55.01; Wed, 07 Apr 2021 13:55:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=HatXvphb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235512AbhDGLiW (ORCPT + 99 others); Wed, 7 Apr 2021 07:38:22 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:16189 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234756AbhDGLiW (ORCPT ); Wed, 7 Apr 2021 07:38:22 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1617795493; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=BlfJ7ChYdm5fsjVC9Gacn3nxjSF5AqDGwGm8a4pwp7c=; b=HatXvphbHuuL4IppFUZt6OZ8UaDcd4osDcAsXukFS70M9STuXPXpmNwfdlhuSSbpGee91bUm tn3xlXPwMAeKabSRCc69hKeNxUlWSmjd+3jUbImb4/L0Ymb0+leqi3/F+SlgPZr+8YDxKBsq HvXv+Jf0xTBWYc3DEmt64FNB1EU= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-east-1.postgun.com with SMTP id 606d999c03cfff3452ebcb79 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 07 Apr 2021 11:38:04 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 69158C43461; Wed, 7 Apr 2021 11:38:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id AC1ECC433CA; Wed, 7 Apr 2021 11:37:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org AC1ECC433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Colin King Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Chung-hsien Hsu , "David S . Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] brcmsmac: fix shift on 4 bit masked value References: <20210318164513.19600-1-colin.king@canonical.com> Date: Wed, 07 Apr 2021 14:37:56 +0300 In-Reply-To: <20210318164513.19600-1-colin.king@canonical.com> (Colin King's message of "Thu, 18 Mar 2021 16:45:13 +0000") Message-ID: <877dlenx4b.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin King writes: > From: Colin Ian King > > The calculation of offtune_val seems incorrect, the u16 value in > pi->tx_rx_cal_radio_saveregs[2] is being masked with 0xf0 and then > shifted 8 places right so that always ends up as a zero result. I > believe the intended shift was 4 bits to the right. Fix this. > > [Note: not tested, I don't have the H/W] > > Addresses-Coverity: ("Operands don't affect result") > Fixes: 5b435de0d786 ("net: wireless: add brcm80211 drivers") > Signed-off-by: Colin Ian King Can someone ack this? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches