Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: QrnEcWLWy5zMGeR9zOzdL8FmVSy+hdDQsfmw5cky2eYQ96jYDTcbu60pytDngWV5LGepd0xtg+
 ms9NUQ09BxogX7BgzYBLDFIzs9jTUXlwugcIGqbI+amhjNgNoL5LAVvJwNV7wzUBTCFhsKojxR
 MI9hnKpF/dnYUGgtS4sjwUUbXnh6nlMpf5w1BtHmRmWot/1iBTooHPY6sefc/ImT1vM9Wjm9A4
 f3/M0m/+3dcbGHj6d3Fbwqm57GarCUCqiFaFhPWVLy4FUcq/s+pl51USCcPGqy6j3NpvfeRgfR
 VLw=
From:   Damien Le Moal <Damien.LeMoal@wdc.com>
To:     kernel test robot <oliver.sang@intel.com>
CC:     Jens Axboe <axboe@kernel.dk>,
        Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "lkp@lists.01.org" <lkp@lists.01.org>,
        "lkp@intel.com" <lkp@intel.com>
Subject: Re: [null_blk] de3510e52b: blktests.block.014.fail
Thread-Topic: [null_blk] de3510e52b: blktests.block.014.fail
Thread-Index: AQHXK6mdYy0b2r7TZEO50jg8+Qg5bg==
Date:   Wed, 7 Apr 2021 12:29:11 +0000
Message-ID: <BL0PR04MB651491ED14D710890187B3D1E7759@BL0PR04MB6514.namprd04.prod.outlook.com>
References: <20210407085942.GF22260@xsang-OptiPlex-9020>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 5fbfbdbb-4fd4-4cbd-3037-08d8f9c0bfcc
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2021 12:29:11.8587
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xroX0J5+snuS4bVCUROvTEOrGFboxwJjqAha0d3iShj2q1zKs/HP2lJpMhQV0PnXphwCTPUn3keIUwPVz12cqg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB7008
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2021/04/07 18:02, kernel test robot wrote:=0A=
> =0A=
> =0A=
> Greeting,=0A=
> =0A=
> FYI, we noticed the following commit (built with gcc-9):=0A=
> =0A=
> commit: de3510e52b0a398261271455562458003b8eea62 ("null_blk: fix command =
timeout completion handling")=0A=
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master=0A=
> =0A=
> =0A=
> in testcase: blktests=0A=
> version: blktests-x86_64-a210761-1_20210124=0A=
> with following parameters:=0A=
> =0A=
> 	disk: 1SSD=0A=
> 	test: nvme-group-00=0A=
> 	ucode: 0x11=0A=
> =0A=
> =0A=
> =0A=
> on test machine: 288 threads Intel(R) Xeon Phi(TM) CPU 7295 @ 1.50GHz wit=
h 80G memory=0A=
> =0A=
> caused below changes (please refer to attached dmesg/kmsg for entire log/=
backtrace):=0A=
> =0A=
> =0A=
> =0A=
> If you fix the issue, kindly add following tag=0A=
> Reported-by: kernel test robot <oliver.sang@intel.com>=0A=
> =0A=
> =0A=
> block/014 (run null-blk with blk-mq and timeout injection configured)=0A=
> block/014 (run null-blk with blk-mq and timeout injection configured) [fa=
iled]=0A=
>     runtime  ...  71.624s=0A=
>     --- tests/block/014.out     2021-01-24 06:04:08.000000000 +0000=0A=
>     +++ /mnt/nvme-group-00/nodev/block/014.out.bad      2021-04-06 09:21:=
25.133971868 +0000=0A=
>     @@ -1,2 +1,377 @@=0A=
>      Running block/014=0A=
>     +dd: error reading '/dev/nullb0': Connection timed out=0A=
>     +dd: error reading '/dev/nullb0': Connection timed out=0A=
>     +dd: error reading '/dev/nullb0': Connection timed out=0A=
>     +dd: error reading '/dev/nullb0': Connection timed out=0A=
>     +dd: error reading '/dev/nullb0': Connection timed out=0A=
>     +dd: error reading '/dev/nullb0': Connection timed out=0A=
>     ...=0A=
>     (Run 'diff -u tests/block/014.out /mnt/nvme-group-00/nodev/block/014.=
out.bad' to see the entire diff)=0A=
=0A=
This is not a kernel bug. It is a problem with blktest. Before my patch, th=
e=0A=
timeout error was not propagated back to the user. It is now and causes dd =
to=0A=
fail. blktest seeing dd failing reports the test as failed. On the kernel s=
ide,=0A=
all is good, the reqs are completed as expected.=0A=
=0A=
Note that the timeout error is reported back as is, using BLK_STS_TIMEOUT w=
hich=0A=
becomes ETIMEDOUT, hence the "Connection timed out" error message. May be w=
e=0A=
should use the more traditional EIO ? Jens ?=0A=
=0A=
In any case, I will send a patch to fix blktest block/014.=0A=
=0A=
=0A=
> =0A=
> =0A=
> =0A=
> To reproduce:=0A=
> =0A=
>         git clone https://github.com/intel/lkp-tests.git=0A=
>         cd lkp-tests=0A=
>         bin/lkp install                job.yaml  # job file is attached i=
n this email=0A=
>         bin/lkp split-job --compatible job.yaml=0A=
>         bin/lkp run                    compatible-job.yaml=0A=
> =0A=
> =0A=
> =0A=
> ---=0A=
> 0DAY/LKP+ Test Infrastructure                   Open Source Technology Ce=
nter=0A=
> https://lists.01.org/hyperkitty/list/lkp@lists.01.org       Intel Corpora=
tion=0A=
> =0A=
> Thanks,=0A=
> Oliver Sang=0A=
> =0A=
=0A=
=0A=
-- =0A=
Damien Le Moal=0A=
Western Digital Research=0A=