Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210402192054.7934-1-dariobin@libero.it> <CAL_JsqKkpZw_BmcCXUzahF-FkQ=vb7mb_s95Lm2G7pWo0=dqNA@mail.gmail.com>
 <1727466283.11523.1617746554330@mail1.libero.it> <CAL_JsqLd+BxW9T99Sx9vgEkxdbMFe+tL7X_nZ7ExvRxVd_9GNQ@mail.gmail.com>
 <1044574275.383115.1617779265390@mail1.libero.it>
In-Reply-To: <1044574275.383115.1617779265390@mail1.libero.it>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Wed, 7 Apr 2021 07:52:27 -0500
Message-ID: <CAL_JsqLcus=Y5nOuV1wiAiVb1mTq9N8xqJpGJD6ip+Ec_6YDyw@mail.gmail.com>
Subject: Re: [PATCH 0/2] fdt: translate address if #size-cells = <0>
To:     Dario Binacchi <dariobin@libero.it>,
        Tony Lindgren <tony@atomide.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Bin Meng <bmeng.cn@gmail.com>,
        Frank Rowand <frowand.list@gmail.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Tero Kristo <kristo@kernel.org>, devicetree@vger.kernel.org,
        linux-clk <linux-clk@vger.kernel.org>,
        linux-omap <linux-omap@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Apr 7, 2021 at 2:07 AM Dario Binacchi <dariobin@libero.it> wrote:
>
>
> > Il 07/04/2021 03:16 Rob Herring <robh+dt@kernel.org> ha scritto:
> >
> >
> > On Tue, Apr 6, 2021 at 5:02 PM Dario Binacchi <dariobin@libero.it> wrote:
> > >
> > >
> > > > Il 06/04/2021 16:06 Rob Herring <robh+dt@kernel.org> ha scritto:
> > > >
> > > >
> > > > On Fri, Apr 2, 2021 at 2:21 PM Dario Binacchi <dariobin@libero.it> wrote:
> > > > >
> > > > >
> > > > > The series comes from my commit in U-boot
> > > > > d64b9cdcd4 ("fdt: translate address if #size-cells = <0>")
> > > > > and from the subsequent exchange of emails at the end of which I was
> > > > > suggested to send the patch to the linux kernel
> > > > > (https://patchwork.ozlabs.org/project/uboot/patch/1614324949-61314-1-git-send-email-bmeng.cn@gmail.com/).
> > > >
> > > > It's 'ranges' that determines translatable which is missing from the
> > > > DT. This should have not had a 0 size either though maybe we could
> > > > support that.
> > >
> > > I have replied to the email you sent to the u-boot mailing list
> > >
> > > >
> > > > Does the DT have to be updated anyways for your spread spectrum support?
> > >
> > > The spread spectrum support patch does not need this patch to work. They belong
> > > to two different series.
> >
> > That's not what I asked. Is the spread spectrum support forcing a DT
> > update for users?
>
> Yes, the deltam and modfreq registers must be added to the DPLL clocks.

That's a shame given this dts has been mostly untouched since 2013.

> > If the DT has to be changed anyways (not really
> > great policy), then you could fix this in the DT at the same time.
>
> I could put the fix to the device tree in that series, although I wouldn't
> create a single patch to fix and add the SSC registers. First the size-cells = <0>
> fix patch and then the SSC patch.
> Do you agree?

By at the same time, I really just meant within 1 release.

But I'd like to hear TI maintainers' thoughts on this.

Rob