Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: dEqmLSK0N9cznX5fL/uO3CIp+F433jR7OhgbUBvIo7h3VrMUGyg7Xq3DNxjmet2ycR+oh9HDtK
 DBaYBLhywqmg==
IronPort-SDR: WnUqqWXZL7oCyhW0EIInumpJdSfewC5ZnwxSWTxF1srzHQgl/wlwEVB4Kh7Jasr13leAQjiV4B
 JfixiK8CSWug==
From:   Jani Nikula <jani.nikula@linux.intel.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-kernel@vger.kernel.org
Cc:     Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v1 1/1] drm/i915: Include only needed headers in ascii85.h
In-Reply-To: <20210407122337.77493-1-andriy.shevchenko@linux.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <20210407122337.77493-1-andriy.shevchenko@linux.intel.com>
Date:   Wed, 07 Apr 2021 15:46:37 +0300
Message-ID: <87h7kijm8i.fsf@intel.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Wed, 07 Apr 2021, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> The ascii85.h is user of exactly two headers, i.e. math.h and types.h.
> There is no need to carry on entire kernel.h.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

That's hardly drm/i915 specific!

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

But who's going to pick it up and, hopefully, change the subject prefix
to ascii85 or something?

> ---
>  include/linux/ascii85.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/ascii85.h b/include/linux/ascii85.h
> index 4cc40201273e..83ad775ad0aa 100644
> --- a/include/linux/ascii85.h
> +++ b/include/linux/ascii85.h
> @@ -8,7 +8,8 @@
>  #ifndef _ASCII85_H_
>  #define _ASCII85_H_
>  
> -#include <linux/kernel.h>
> +#include <linux/math.h>
> +#include <linux/types.h>
>  
>  #define ASCII85_BUFSZ 6

-- 
Jani Nikula, Intel Open Source Graphics Center