Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.112.34 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.112.34; helo=mail.nvidia.com;
Subject: Re: [PATCH] media: Fix compilation error
To:     Hans Verkuil <hverkuil@xs4all.nl>,
        Bixuan Cui <cuibixuan@huawei.com>,
        <linux-kernel@vger.kernel.org>, <linux-media@vger.kernel.org>
CC:     <thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
        <skomatineni@nvidia.com>, <mchehab@kernel.org>,
        <treding@nvidia.com>, <john.wanghui@huawei.com>
References: <20210402074017.49009-1-cuibixuan@huawei.com>
 <c5b9fc40-0d52-4a31-2e73-14ec07434af4@xs4all.nl>
From:   Mikko Perttunen <mperttunen@nvidia.com>
Message-ID: <78d1052a-9f9a-315b-0bba-4628a6fb3ddb@nvidia.com>
Date:   Wed, 7 Apr 2021 16:45:34 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <c5b9fc40-0d52-4a31-2e73-14ec07434af4@xs4all.nl>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2021 13:45:39.9528
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 977937d1-334c-4b0c-05f6-08d8f9cb6e82
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT019.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5466
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7.4.2021 16.29, Hans Verkuil wrote:
> On 02/04/2021 09:40, Bixuan Cui wrote:
>> Fix the error:
>>
>> drivers/staging/media/tegra-video/vi.c:1180:4:
>> error: implicit declaration of function 'host1x_syncpt_free' [-Werror,-Wimplicit-function-declaration]
> 
> Against what tree is this being built? The mainline kernel doesn't have
> host1x_syncpt_put, only host1x_syncpt_free.

This change was done only very recently, it's in linux-next and 
submitted for 5.13. I missed this one host1x_syncpt_free call in vi.c, 
but Thierry has already applied an equivalent patch on his end so the 
issue should be resolved.

Thanks,
Mikko

> 
> Also, the subject line is very vague, something like this is much more descriptive:
> 
> [PATCH] media: tegra-video: replace host1x_syncpt_free by host1x_syncpt_put
> 
> Regards,
> 
> 	Hans
> 
>>
>> Fixes: 3028a00c55bf ('gpu: host1x: Cleanup and refcounting for syncpoints')
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
>> ---
>>   drivers/staging/media/tegra-video/vi.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/media/tegra-video/vi.c b/drivers/staging/media/tegra-video/vi.c
>> index 7e0cb5529b49..df5ca3596470 100644
>> --- a/drivers/staging/media/tegra-video/vi.c
>> +++ b/drivers/staging/media/tegra-video/vi.c
>> @@ -1177,7 +1177,7 @@ static int tegra_channel_host1x_syncpt_init(struct tegra_vi_channel *chan)
>>   		mw_sp = host1x_syncpt_request(&vi->client, flags);
>>   		if (!mw_sp) {
>>   			dev_err(vi->dev, "failed to request memory ack syncpoint\n");
>> -			host1x_syncpt_free(fs_sp);
>> +			host1x_syncpt_put(fs_sp);
>>   			ret = -ENOMEM;
>>   			goto free_syncpts;
>>   		}
>>
>