Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp887914pxf; Wed, 7 Apr 2021 14:11:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx128mxNn37lH4+c6F/rXa8UN+/mqjIYiwnQhmVc/brY7G76+bq2e/NXYirvZaOShdhDmR+ X-Received: by 2002:a92:d811:: with SMTP id y17mr1783649ilm.221.1617829907482; Wed, 07 Apr 2021 14:11:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617829907; cv=none; d=google.com; s=arc-20160816; b=T3X4poR/vY4PPoEcbTwVUXh4tPsNM7IcTAHhhdnvrUZFSQo8BfXcbe/OQV+tmtQTYv TA8GWY2M9qoXtAz4NFU5OHjwEyaWlJREmZxPRFeH1Q7n75+GEghu5w0u64LIUuaDgcPR yXE26bBsL0IV+Eyl7ewZx6+iEGvlVsJ75jb4fTgpT7IJC8bdnQqG895VRrEvoHMkiOhh bVt83jd9NaMvIvNbkAVfVrnyo1/eHay/fp9FzD+EdmkpLXS51PNzRcaPWXxeeybOGIdE QhA3Jbpr8RMZdujEf3KZ4ktIViNiUA0oQPjMlZ69gP/Xkw1bO7uAAhrWZvALDc6rEua8 2jQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=PR0/w62JxrIlFoUOVRaVHU0oEIHTvmIAoGy/SaAMJ/k=; b=JqXUe4IUeA5BzPrZv4Sh9vcR4/mbaAF3xy+k6rs03R5IJkEffAdWiTqQdMGaOo7qFi DarFvXM5ZSSh3+ifqAGdXMv5qqveztaIimkaw7YhKsqqvOLEdEeuQOWy7AlAftSodmoB db8LrFt5nl9fc5STdwmr1WSH3fs2gi9P383PjYRc2IZl+TpiQtbzbD3HMe37Pxi47QzL HSY767UOovBK/T1jn6UQTpe82UDsp/tASnl82FxT9Vc+0I0D7Y71AHDGQ2W8j0D4Y93s D+nfS+2awSbXeOZUQQM1KklTO9sqfex2TbDOocO64m4JAKSAj+JlWoYpbxYnnfR2UTP1 Ttfg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y16si22111666jaq.71.2021.04.07.14.11.34; Wed, 07 Apr 2021 14:11:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353350AbhDGPHa (ORCPT + 99 others); Wed, 7 Apr 2021 11:07:30 -0400 Received: from mga11.intel.com ([192.55.52.93]:41706 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242586AbhDGPH3 (ORCPT ); Wed, 7 Apr 2021 11:07:29 -0400 IronPort-SDR: uqt+0s0C/M44787dW2QEuIxYoYVBk4dz3nZf7R4RGvWk3jvb0AzmXbhwuLvD7WFOLwguR+XZCr oU2b5i5pt/kA== X-IronPort-AV: E=McAfee;i="6000,8403,9947"; a="190123293" X-IronPort-AV: E=Sophos;i="5.82,203,1613462400"; d="scan'208";a="190123293" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2021 08:07:19 -0700 IronPort-SDR: DoDEm7SOJomqulRq1VRGRBl1KuHBQIu9o8e/pOc5LbOmC/NuW4+Qm41Cf9B8Z173F84x8bhkqz qrl0Xe4m239Q== X-IronPort-AV: E=Sophos;i="5.82,203,1613462400"; d="scan'208";a="519469002" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2021 08:07:15 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lU9lw-0022JS-AH; Wed, 07 Apr 2021 18:07:12 +0300 Date: Wed, 7 Apr 2021 18:07:12 +0300 From: Andy Shevchenko To: Petr Mladek Cc: Stephen Boyd , Andrew Morton , linux-kernel@vger.kernel.org, Jiri Olsa , Alexei Starovoitov , Jessica Yu , Evan Green , Hsin-Yi Wang , Steven Rostedt , Sergey Senozhatsky , Rasmus Villemoes , linux-doc@vger.kernel.org, Matthew Wilcox Subject: Re: [PATCH v3 04/12] module: Add printk format to add module build ID to stacktraces Message-ID: References: <20210331030520.3816265-1-swboyd@chromium.org> <20210331030520.3816265-5-swboyd@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 07, 2021 at 04:54:33PM +0200, Petr Mladek wrote: > On Tue 2021-03-30 20:05:12, Stephen Boyd wrote: > > Let's make kernel stacktraces easier to identify by including the build > > ID[1] of a module if the stacktrace is printing a symbol from a module. > > This makes it simpler for developers to locate a kernel module's full > > debuginfo for a particular stacktrace. Combined with > > scripts/decode_stracktrace.sh, a developer can download the matching > > debuginfo from a debuginfod[2] server and find the exact file and line > > number for the functions plus offsets in a stacktrace that match the > > module. This is especially useful for pstore crash debugging where the > > kernel crashes are recorded in something like console-ramoops and the > > recovery kernel/modules are different or the debuginfo doesn't exist on > > the device due to space concerns (the debuginfo can be too large for > > space limited devices). ... > It shows wrong build id for vmlinux. > And it does not show the build if for the module at all. From your previous messages and this seems like virtualization breaks the access / use of build ID :-( -- With Best Regards, Andy Shevchenko