Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: LmHq+2fnsAQ5px8h9OhWAgAxhlraOm13asDDg0eg2s0txJz9gvlw+MesJNJNnvg1NRbqMs3SUR
 CLEyOJIX4igQ==
IronPort-SDR: 75+igPB4OKJBCJ97rxPE+M2owKYHWZCa5M+tjR8PpGDzpaCeP58tFetO/OuJiJsJtRew3Xa5gP
 w6eIs/VM6UOQ==
Date:   Wed, 7 Apr 2021 08:24:17 -0700
From:   Andi Kleen <ak@linux.intel.com>
To:     Sean Christopherson <seanjc@google.com>
Cc:     Andy Lutomirski <luto@amacapital.net>,
        Andy Lutomirski <luto@kernel.org>,
        "Kuppuswamy, Sathyanarayanan" 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Dave Hansen <dave.hansen@intel.com>,
        Kirill Shutemov <kirill.shutemov@linux.intel.com>,
        Kuppuswamy Sathyanarayanan <knsathya@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Raj Ashok <ashok.raj@intel.com>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/1] x86/tdx: Handle MWAIT, MONITOR and WBINVD
Message-ID: <20210407152417.GM1285835@tassilo.jf.intel.com>
References: <YGNAQrWMl3AZQ3HG@google.com>
 <4DD05B91-13B3-4842-A215-C8DC6F34F219@amacapital.net>
 <YGNYhWXe57FMm6Ku@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YGNYhWXe57FMm6Ku@google.com>
Precedence: bulk

> Hmm, I forgot about that quirk.  I would expect the TDX Module to inject a #GP
> for that case.  I can't find anything in the spec that confirms or denies that,
> but injecting #VE would be weird and pointless.
> 
> Andi/Sathya, the TDX Module spec should be updated to state that XSETBV will
> #GP at CPL!=0.  If that's not already the behavior, the module should probably
> be changed...

I asked about this and the answer was that XSETBV behaves architecturally inside
a TD (no #VE), thus there is nothing to document.

-Andi