Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 7 Apr 2021 17:25:30 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Like Xu <like.xu@linux.intel.com>
Cc:     Sean Christopherson <seanjc@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>, eranian@google.com,
        andi@firstfloor.org, kan.liang@linux.intel.com,
        wei.w.wang@intel.com, Wanpeng Li <wanpengli@tencent.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, kvm@vger.kernel.org,
        x86@kernel.org, linux-kernel@vger.kernel.org,
        Andi Kleen <ak@linux.intel.com>,
        Luwei Kang <luwei.kang@intel.com>
Subject: Re: [PATCH v4 07/16] KVM: x86/pmu: Add IA32_PEBS_ENABLE MSR
 emulation for extended PEBS
Message-ID: <YG3O6rpx2bSt5D+O@hirez.programming.kicks-ass.net>
References: <20210329054137.120994-1-like.xu@linux.intel.com>
 <20210329054137.120994-8-like.xu@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210329054137.120994-8-like.xu@linux.intel.com>
Precedence: bulk


On Mon, Mar 29, 2021 at 01:41:28PM +0800, Like Xu wrote:
> +	if (vcpu->arch.perf_capabilities & PERF_CAP_PEBS_FORMAT) {
> +		if (vcpu->arch.perf_capabilities & PERF_CAP_PEBS_BASELINE) {
> +			pmu->pebs_enable_mask = ~pmu->global_ctrl;
> +			pmu->reserved_bits &= ~ICL_EVENTSEL_ADAPTIVE;
> +			for (i = 0; i < pmu->nr_arch_fixed_counters; i++)
> +				pmu->fixed_ctr_ctrl_mask &=
> +					~(1ULL << (INTEL_PMC_IDX_FIXED + i * 4));

{ }

> +		} else
> +			pmu->pebs_enable_mask = ~((1ull << pmu->nr_arch_gp_counters) - 1);

{ }

> +	} else {
> +		vcpu->arch.perf_capabilities &= ~PERF_CAP_PEBS_MASK;

as you already do here..

> +	}
>  }