Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp892414pxf; Wed, 7 Apr 2021 14:19:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzMdMMeBidGNv88Zq7sjH58HHqpiHRQuA7Qoo1CS4NZERdFwQoVmCUQSYLaIB4SzVXZwhcB X-Received: by 2002:a17:906:c7cc:: with SMTP id dc12mr6066635ejb.423.1617830360646; Wed, 07 Apr 2021 14:19:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617830360; cv=none; d=google.com; s=arc-20160816; b=mtQKkkr4x8TiucTAizEC2guaielNXRrExx0sJGhW1w/lXo2m1Q19odouPri+XfYcYe IcBR8+XZgK77SOmX5zGKDpHRnOS1g0BW2fEitC7QsLfoIOIjiGfOh0N6ewNPkHp3fyo5 tN1ExR4IkfJGURU62blmwYdrwixKqqR+2VIFE2OuTojo9nchbgT4xnXuIJ+ER4aLksgz U2oxr5LbwUD1VJtVr/EAHrZ3SFtDGRjo6/02/yVrNSz+fVtDIeTILVvjptKFVZE39aIl r9eXw4k79IOjK9TRalxZqUEzTP7jE/44qDiwTC5ba3Cl0UtCMYueK1uKlmNbAxuZOspA THsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=hw1V3rwzsoLcWZFECIqFfEWpyAH3NEfp9+b3fQtCOQU=; b=tt/5teC8nfZ6v+WF0dnf9Aq30ds0PtD+VKkDB8q1zufbik7uNu0M+sPfVZOxQzcDB7 hj/BelW4ESSRtm2tI9Qov0ghjiugX9er/NfzORhk9k1N3n3Fg+BuqZcippTVbl5/5KbZ +cGLhP3WJQg1OKRN4Pa619go3UdXsceSq+uXk4u+UjEg4h8qUCl1fZMU3G5Q/KpFt52Y t0XgJhAvxNyjv9/AkqbTD56LIimJz/7NJTCljj6UVQzqmI+vM/rBh3fpf92RZYqa59+K JDTViSK4oyXIlScMTAy/IVAzeZTrT7K6QG8+1aie3bHhqGRViwchAeYCny+Dv9/6sw7R T8JA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=UfyzGWNs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i6si20287227edu.313.2021.04.07.14.18.57; Wed, 07 Apr 2021 14:19:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=UfyzGWNs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353607AbhDGPay (ORCPT + 99 others); Wed, 7 Apr 2021 11:30:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:39232 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353606AbhDGPaq (ORCPT ); Wed, 7 Apr 2021 11:30:46 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 28ED061284; Wed, 7 Apr 2021 15:30:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617809436; bh=qA1K7GXPgJggIo7yDSDd0shoNwNJAxbUw0JD2TvPcag=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UfyzGWNsF1bmdjTOmt5+jEypgyfgMvhFIkBUPZVuqaSPuLIKJIqK6Owskw2/nQYud jDZ9O4GG3VMLuz98vXGXANX7n3EkLxgaTACr/lXmk3CWecq0wlYB0lCEac2tnGAVbf 9GSywokjiNUpEh5Nfz7rwuDxndPapF0uPk3upcOg= Date: Wed, 7 Apr 2021 17:30:34 +0200 From: Greg KH To: Fabio Aiuto Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/19] drivers: rtl8723bs: rewrite comparison to null Message-ID: References: <0c6d53c851d1b07eb0183108e0bad7b4f273f04b.1617802415.git.fabioaiuto83@gmail.com> <20210407152533.GA1590@agape.jhs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210407152533.GA1590@agape.jhs> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 07, 2021 at 05:25:34PM +0200, Fabio Aiuto wrote: > On Wed, Apr 07, 2021 at 05:14:00PM +0200, Greg KH wrote: > > On Wed, Apr 07, 2021 at 03:49:31PM +0200, Fabio Aiuto wrote: > > > fix following post-commit hook checkpatch warnings: > > > > > > CHECK: Comparison to NULL could be written "!psta" > > > 97: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:2115: > > > + if (psta == NULL) > > > > > > Signed-off-by: Fabio Aiuto > > > --- > > > drivers/staging/rtl8723bs/core/rtw_ap.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Nit, your subject line has "drivers:" not "staging:" here. Be a bit > > more careful next time please. > > > > thanks, > > > > greg k-h > > sorry, you can drop them off the staging-testing branch and I will resend you all if you want, Nah, it's not worth it, I'll keep them for now :)