Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 7 Apr 2021 19:51:38 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     min.li.xe@renesas.com
Cc:     derek.kiernan@xilinx.com, dragan.cvetic@xilinx.com, arnd@arndb.de,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/2] misc: Add Renesas Synchronization
 Management Unit (SMU) support
Message-ID: <YG3xKlSrOZvrIr3z@kroah.com>
References: <1617816815-3785-1-git-send-email-min.li.xe@renesas.com>
 <1617816815-3785-2-git-send-email-min.li.xe@renesas.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1617816815-3785-2-git-send-email-min.li.xe@renesas.com>
Precedence: bulk

On Wed, Apr 07, 2021 at 01:33:35PM -0400, min.li.xe@renesas.com wrote:
> +/**
> + * struct rsmu_cdev - Driver data for RSMU character device
> + * @name: rsmu device name

Why not use the miscdev name field?

> + * @dev: pointer to platform device

So it's a parent?  Why not make this a real platform_device pointer and
not a device pointer?

> + * @mfd: pointer to MFD device

You are properly handling the reference count of this and the platform
device pointer when you save it off, right?  Please check.

> + * @miscdev: character device handle
> + * @lock: mutex to protect operations from being interrupted

What operations?

> + * @type: rsmu device type
> + * @ops: rsmu device methods
> + * @index: rsmu device index

Index into what?

> --- /dev/null
> +++ b/drivers/misc/rsmu_cm.c
> @@ -0,0 +1,166 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * This driver is developed for the IDT ClockMatrix(TM) of
> + * timing and synchronization devices.
> + *
> + * Copyright (C) 2019 Integrated Device Technology, Inc., a Renesas Company.

Note, it's 2021 :)

thanks,

greg k-h