Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Santosh Shilimkar <santosh.shilimkar@oracle.com>
To:     Aditya Pakki <pakki001@umn.edu>
CC:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net/rds: Avoid potential use after free in
 rds_send_remove_from_sock
Thread-Topic: [PATCH] net/rds: Avoid potential use after free in
 rds_send_remove_from_sock
Thread-Index: AQHXK9uOg9SlFRiZTUOkxXjE4FDO2A==
Date:   Wed, 7 Apr 2021 18:26:41 +0000
Message-ID: <211FD3E3-54AF-41A4-91BF-EEB01680A1CC@oracle.com>
References: <20210407000913.2207831-1-pakki001@umn.edu>
In-Reply-To: <20210407000913.2207831-1-pakki001@umn.edu>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1512169AD23F3246B52536486293A717@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: bbe841d8-093e-4de3-c2e5-08d8f9f2b112
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2021 18:26:42.0034
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: EBvfAamoxu5/LJn/1kS2q/YhO6bSas78wVnjWTXOru6DHK/wwiFnh+i8su12JZKxClUDi/3SbCzHBSO6aWyw7wv9VtsezeaPPNqbR2X1eY4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4161
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9947 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=994
 malwarescore=0 mlxscore=0 phishscore=0 spamscore=0 bulkscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2104060000 definitions=main-2104070127
X-Proofpoint-ORIG-GUID: yCVItoOvyK4cDCsQSXGobs12D9Gvrt5t
X-Proofpoint-GUID: yCVItoOvyK4cDCsQSXGobs12D9Gvrt5t
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9947 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 priorityscore=1501
 suspectscore=0 phishscore=0 mlxlogscore=999 spamscore=0 malwarescore=0
 mlxscore=0 bulkscore=0 impostorscore=0 adultscore=0 clxscore=1011
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000
 definitions=main-2104070126
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Apr 6, 2021, at 5:09 PM, Aditya Pakki <pakki001@umn.edu> wrote:
>=20
> In case of rs failure in rds_send_remove_from_sock(), the 'rm' resource
> is freed and later under spinlock, causing potential use-after-free.
> Set the free pointer to NULL to avoid undefined behavior.
>=20
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
> ---
> net/rds/message.c | 1 +
> net/rds/send.c    | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)

Looks fine by me. Thanks.

Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>