Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210401183216.443C4443@viggo.jf.intel.com> <20210401183229.B2360AEA@viggo.jf.intel.com>
In-Reply-To: <20210401183229.B2360AEA@viggo.jf.intel.com>
From:   Wei Xu <weixugc@google.com>
Date:   Wed, 7 Apr 2021 11:40:13 -0700
Message-ID: <CAAPL-u-OgmT+R=txfO_rFaYLKC0UZ5xEmFOY3spVHEmk_r4iSQ@mail.gmail.com>
Subject: Re: [PATCH 07/10] mm/vmscan: add helper for querying ability to age
 anonymous pages
To:     Dave Hansen <dave.hansen@linux.intel.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        shy828301@gmail.com, Greg Thelen <gthelen@google.com>,
        David Rientjes <rientjes@google.com>, ying.huang@intel.com,
        Dan Williams <dan.j.williams@intel.com>, david@redhat.com,
        osalvador@suse.de
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

> +/*
> + * Anonymous LRU management is a waste if there is
> + * ultimately no way to reclaim the memory.
> + */
> +bool anon_should_be_aged(struct lruvec *lruvec)
> +{
> +       struct pglist_data *pgdat = lruvec_pgdat(lruvec);
> +
> +       /* Aging the anon LRU is valuable if swap is present: */
> +       if (total_swap_pages > 0)
> +               return true;
> +
> +       /* Also valuable if anon pages can be demoted: */
> +       if (next_demotion_node(pgdat->node_id) >= 0)
> +               return true;
> +
> +       /* No way to reclaim anon pages.  Should not age anon LRUs: */
> +       return false;
> +}

anon_should_be_aged() doesn't really need "lruvec".  It essentially
answers whether the pages of the given node can be swapped or demoted.
So it would be clearer and less confusing if anon_should_be_aged()
takes "pgdat" instead of "lruvec" as the argument.  The call to
mem_cgroup_lruvec(NULL, pgdat) in age_active_anon() can then be removed
as well.