Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-HdrOrdr: =?us-ascii?q?A9a23=3Ab65nEaqqUu3gUIbyN2DEw68aV5vDL9V00zAX?=
 =?us-ascii?q?/kB9WHVpW+aT/vrOoN0w0xjohDENHEw6kdebN6WaBV/a/5h54Y4eVI3SOjXOkm?=
 =?us-ascii?q?2uMY1k8M/e0yTtcheOkdJ1+IVBV+xFCNP2BUVnlsqS2mOFOvsp3dXvys2VrMjE?=
 =?us-ascii?q?yXMFd21XQoFmqzx0EwOKVnBxLTM2ZqYRMZqH+45uvDCgeWsaB/7LekUteujYup?=
 =?us-ascii?q?nqufvdEGM7Ljsm8hTLtDWz9dfBYmel9zIfSS4K/bA57WPemRf47anLiYDE9jb5?=
 =?us-ascii?q?23XI55pb3PvNo+EiOOWpiswYbgrhkRypYoMJYczngBkNu+2k5Fsnl9PByi1QRv?=
 =?us-ascii?q?hb0H/acmGrrRaF4WCJuwoG0HPsxUSVhnHuu6XCNVAHIvFMnIdINibegnBOgPhH?=
 =?us-ascii?q?zKlJ02iF3qAnaC/ooSKV3bb1fiAvvlaopz4YnfQLiXtEXc8ldKZJtoAE5ipuYe?=
 =?us-ascii?q?Y9NRO/xoA7MfVkSPrR7OxRdjqhHgrkl1gq7tywf2g5WiyLSEgausCTzlFt7QtE?=
 =?us-ascii?q?5npd6swDv2sKsKkwQZlc5+jCL+BBmbxUQtUNBJgNdNspcI+YCnHtXRmJCm6ULF?=
 =?us-ascii?q?j9fZt3Q07wlw=3D=3D?=
Date:   Wed, 7 Apr 2021 21:02:32 +0200 (CEST)
From:   Julia Lawall <julia.lawall@inria.fr>
To:     Liam Beguin <liambeguin@gmail.com>, mturquette@baylibre.com,
        sboyd@kernel.org
cc:     linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, robh+dt@kernel.org,
        kbuild-all@lists.01.org
Subject: [PATCH] clk: fix for_each_child.cocci warnings
Message-ID: <alpine.DEB.2.22.394.2104072100410.11549@hadrien>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

From: kernel test robot <lkp@intel.com>

For_each_child_of_node should have of_node_put() before goto.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

CC: Liam Beguin <lvb@xiphos.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

url:    https://github.com/0day-ci/linux/commits/Liam-Beguin/add-support-for-the-lmk04832/20210407-085408
base:   f40ddce88593482919761f74910f42f4b84c004b
:::::: branch date: 9 hours ago
:::::: commit date: 9 hours ago

 clk-lmk04832.c |    1 +
 1 file changed, 1 insertion(+)

--- a/drivers/clk/clk-lmk04832.c
+++ b/drivers/clk/clk-lmk04832.c
@@ -1159,6 +1159,7 @@ static int lmk04832_probe(struct spi_dev
 		if (ret) {
 			dev_err(lmk->dev, "missing reg property in child: %s\n",
 				child->full_name);
+			of_node_put(child);
 			goto err_disable_oscin;
 		}