Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Min Li <min.li.xe@renesas.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "derek.kiernan@xilinx.com" <derek.kiernan@xilinx.com>,
        "dragan.cvetic@xilinx.com" <dragan.cvetic@xilinx.com>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next v2 2/2] misc: Add Renesas Synchronization
 Management Unit (SMU) support
Thread-Topic: [PATCH net-next v2 2/2] misc: Add Renesas Synchronization
 Management Unit (SMU) support
Thread-Index: AQHXK9TmRDzfnJqVl0Sq9GK4xidseaqpU/GAgAAY4uA=
Date:   Wed, 7 Apr 2021 19:43:44 +0000
Message-ID: <OSBPR01MB47733C009A6B6F2F697E12ACBA759@OSBPR01MB4773.jpnprd01.prod.outlook.com>
References: <1617816815-3785-1-git-send-email-min.li.xe@renesas.com>
 <1617816815-3785-2-git-send-email-min.li.xe@renesas.com>
 <YG3vu9XQ94w5dlbp@kroah.com>
In-Reply-To: <YG3vu9XQ94w5dlbp@kroah.com>
Accept-Language: en-CA, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 5d0448ec-74a0-4408-8f80-08d8f9fd74a2
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2021 19:43:45.0738
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: sskr4EArs/19JKAt3W6nuaNqV0L2p3ZHIvVInTVlRMj3St9nkJ2UA9NT5O8QT870kBglXWAWwXfA+o/E+uP0/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSBPR01MB3095
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> Why do you need 4 files here?  Can't you do this all in one?  There's no =
need
> for such a small driver to be split up, that just causes added complexity=
 and
> makes things harder to review and understand.
>=20

We will add more functions and boards down the road. So the abstraction her=
e is for future consideration =20

> >  include/uapi/linux/rsmu.h |  64 +++++++++++
>=20
> Where are you documenting these new custom ioctls?  And why do you even
> need them?
>=20

Other than comments in the header itself, no additional documenting. Do you=
 know if Linux has specific place to document custom ioctls?=20
Renesas software needs to access these ioctls to provide GNSS assisted part=
ial timing support. More specifically, RSMU_GET_STATE would tell us if a sp=
ecific DPLL
is locked to GNSS and RSMU_GET_FFO would tell us how much of frequency offs=
et for the DPLL to lock to the GNSS.

Thanks

Min