Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp918751pxf; Wed, 7 Apr 2021 15:03:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyRFgiwfHSEBPhoCEhsIVMZBNh+wUsWZ4jpEeOCmZNGCS2wJrceV0IiykOXXULHYYOXVdnU X-Received: by 2002:a17:902:d64a:b029:e6:30a6:64e3 with SMTP id y10-20020a170902d64ab02900e630a664e3mr4941720plh.28.1617833025959; Wed, 07 Apr 2021 15:03:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617833025; cv=none; d=google.com; s=arc-20160816; b=HyOlEYqj+FoYIS/T2lR+Qxpjfi6Dkz74t8ymFvtpHNysA0dgTgk41Zup5E0reEUivK 86WGyas24JRivYW8uTJ9Qi91+4egyptLbTl+fSW0+/Q0qq4YwhRYPpmzkQ46N6xxYGlZ CF9vy5Aj2p8Ym1zBQrkFzEo96JM6DKY8acPwnGGxv7+Fo2+BBFYvPsFTqbs7J5T0FfXX eWamz9yFCjSKAvc2AGAwGvUOwc5MVuRFWD8CSEiaHu378HmLofjkYMEiI7QT1U7DAfVt q4Ekk+W4DwSWbepMZNYRF+ye06aM7uXVwRzCqLcTpPJIzrxLNTBu9YBFEr1v8WeiTbVm 0iJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=XBTPgiP3nLciMwfftDldC4pwFhybzZyZl62PVO13P2Y=; b=Wn9ua4D/tuBgGR3a9+OVhI/t7pui628aFoIXsjaqTxyfnv89cYiDGNV4LWUoGq8KpQ +EcBEKmp5+7FfSdNV9itgtGoyCj97A8qGle+qSLQZV5ZuYq/PgmuvsPmogdRIIhXUmQm DxHJ+nlRwH9M+e2xDpftn9nfCI6BPiITxTIGEtZKbeTwxWnkYeyVf1BrJbGBr9LP+ErF KLHvHHOZTn/YUiX4yF/tTlfXxnT2srRDRw/c0Xv0Lre94ZoEcyaP+xpekdR+Jrj8rF/l AtmCCvR0vr68CGGAjcPsbBzbX4NSHYPLXSy5z1r75FOQblUkEYOP2JAZfwhGYzUODgoz ZfbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=X9rT4CRP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id iq19si4702210pjb.113.2021.04.07.15.03.33; Wed, 07 Apr 2021 15:03:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=X9rT4CRP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356285AbhDGU1w (ORCPT + 99 others); Wed, 7 Apr 2021 16:27:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:57764 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244276AbhDGU1V (ORCPT ); Wed, 7 Apr 2021 16:27:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D8D14611EE; Wed, 7 Apr 2021 20:27:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617827222; bh=DapdfZkCmQxiuqMn5+0fag9RbsXzXBztZK5Y2BqkUqE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X9rT4CRPK4Lot0QDWyJSr4PwnWN/TzBK9sxRedCn2FTzKa7PBXqNBXWHXOFAM4CH9 Q6hAltC8DX5LJN9LCPOH0jQAr3gYumPmfqD8xc3Qyr0ErNEyZ07uf9zwpm/+DQjiA1 o16Fg4y+IZxDoSiO5gu/m59HfTiFllfNpil6bCA9b5OeP7BPTQBNW7/g457QH80WiE VhaqRWny/7OStm0hxCM75br2s89+2haVrv+KqaePiNoC145noTYUIioDyFUAxyY3Ly MevEdbEMwfvSLLa1npz6RxRblWQ0yh42XQM/6xaAdtG3LK6aZxBY2r5AO69hxXDCbP XAlwAIpOkiBfQ== From: Mark Brown To: Sameer Pujar , Takashi Iwai , Kuninori Morimoto , Krzysztof Kozlowski , Liam Girdwood , Jaroslav Kysela , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Cc: Mark Brown , Colin King Subject: Re: [PATCH] ASoC: simple-card: fix possible uninitialized single_cpu local variable Date: Wed, 7 Apr 2021 21:26:25 +0100 Message-Id: <161782703230.42756.15970652059464773892.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210407092027.60769-1-krzysztof.kozlowski@canonical.com> References: <20210407092027.60769-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 7 Apr 2021 11:20:27 +0200, Krzysztof Kozlowski wrote: > The 'single_cpu' local variable is assigned by asoc_simple_parse_dai() > and later used in a asoc_simple_canonicalize_cpu() call, assuming the > entire function did not exit on errors. > > However the first function returns 0 if passed device_node is NULL, > thus leaving the variable uninitialized and reporting success. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: simple-card: fix possible uninitialized single_cpu local variable commit: fa74c223b6fd78a5314b4c61b9abdbed3c2185b4 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark