Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/1] of: properly check for error returned by
 fdt_get_name()
From:   Frank Rowand <frowand.list@gmail.com>
To:     Rob Herring <robh@kernel.org>
Cc:     Guenter Roeck <linux@roeck-us.net>,
        Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
        devicetree@vger.kernel.org,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        linux-kernel@vger.kernel.org
References: <20210405032845.1942533-1-frowand.list@gmail.com>
 <20210406192100.GA2050740@robh.at.kernel.org>
 <86171ba4-7251-2a3b-01fe-5da4af3eb8af@gmail.com>
Message-ID: <2c430615-22ac-2769-9348-f6ccbae6e3f7@gmail.com>
Date:   Wed, 7 Apr 2021 16:04:34 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <86171ba4-7251-2a3b-01fe-5da4af3eb8af@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/6/21 3:30 PM, Frank Rowand wrote:
> On 4/6/21 2:21 PM, Rob Herring wrote:
>> On Sun, Apr 04, 2021 at 10:28:45PM -0500, frowand.list@gmail.com wrote:
>>> From: Frank Rowand <frank.rowand@sony.com>
>>>
>>> fdt_get_name() returns error values via a parameter pointer
>>> instead of in function return.  Fix check for this error value
>>> in populate_node() and callers of populate_node().
>>>
>>> Chasing up the caller tree showed callers of various functions
>>> failing to initialize the value of pointer parameters that
>>> can return error values.  Initialize those values to NULL.
>>>
>>> The bug was introduced by
>>> commit e6a6928c3ea1 ("of/fdt: Convert FDT functions to use libfdt")
>>> but this patch can not be backported directly to that commit
>>> because the relevant code has further been restructured by
>>> commit dfbd4c6eff35 ("drivers/of: Split unflatten_dt_node()")
>>>
>>> The bug became visible by triggering a crash on openrisc with:
>>> commit 79edff12060f ("scripts/dtc: Update to upstream version v1.6.0-51-g183df9e9c2b9")
>>> as reported in:
>>> https://lore.kernel.org/lkml/20210327224116.69309-1-linux@roeck-us.net/
>>>
>>> Fixes: commit 79edff12060f ("scripts/dtc: Update to upstream version v1.6.0-51-g183df9e9c2b9")
>>> Reported-by: Guenter Roeck <linux@roeck-us.net>
>>> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
>>>
>>> ---
>>>
>>> This patch papers over the unaligned pointer passed to
>>> of_fdt_unflatten_tree() bug that Guenter reported in
>>> https://lore.kernel.org/lkml/20210327224116.69309-1-linux@roeck-us.net/
>>>
>>> I will create a separate patch to fix that problem.
> 
> Likely to be tomorrow (Wed 4/7).
> 
> -Frank
> 
>>
>> Got an ETA for that?
>>
>> Rob
>> .
>>
> 

The patch to fix the alignment issue is:

  https://lore.kernel.org/linux-devicetree/20210407205110.2173976-1-frowand.list@gmail.com/

Hopefully it will pass testing by Guenter.
  
Sorry about the previous vertical dyslexia response... :-)

-Frank