Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp921281pxf; Wed, 7 Apr 2021 15:07:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZds8q0gehIEtKP4hI1uHr/qZHqmgPBEWG6jjXCvWVUUuBZqB6Mn519j2BAOr8w1yU/+wT X-Received: by 2002:aa7:8681:0:b029:23f:8cf:fb6b with SMTP id d1-20020aa786810000b029023f08cffb6bmr4676486pfo.44.1617833226015; Wed, 07 Apr 2021 15:07:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617833226; cv=none; d=google.com; s=arc-20160816; b=w59yzPyooG8wcpQNRY702iE7YyUgk1QDkJyCI3yhcp8fXjsuZGn8KRiCmwl/dIreFw TsrnZpViO8z471LC399YFh3VUxa9FU+10AterN6WfUjLkeR1ziLAaJWwTRrtKxHwJZv8 C3IDyBCQWpwUjnZz+9kGZn8NWXAZjIB91G52kkWG6acq4z5WiXPEtH8I3t2JujY6lxmb Cv8HP2vxCzaNtf0maZWsLK+JPeuZZ69hFgffTUFZWAUZ2NxXk3m1GCf86MviYijery5T maoYu2gQSTSbWDV+J355mOIMefonWKFvyIB2KCsEuWmOi/bjlnfSNayg9Z+XygCO4sG7 MkDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=a47TEfns2sotKnDxQu666XX2CkzMdMxHYzjBfe8Jyqk=; b=mV/Rmi+IyEvXz9d4I8kEOtkVe+zOECiXlMpcEXPTT4WqlNIyCrC4oCU8HoMUUE/jwQ KlBwcqH4fziUmtEluCOp8ftcm7NPiDpcELr96OTBmkOZbE7aDpsnAxKQAL1WtmMHndhC Ehed5kyoE7Mo8M6RwhLeDPTle7igAgaYtkIf6QyLYWJFLGamRfY0oFF8nJFzBhecVPOM AX2G2Ar3CaoWlL6R87Sc/XI0XG+DsYt4+tjiPW9v50g4O/vkx0RPKZQV2NNvY3vIfbr1 9VIhv//uQeOcSGK8aApcOVaJwqNv7jm20pKdsU7gntBPGr5Fd1iFgL2JmT9ltE01CYL4 CZPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=R73EQ1qQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l12si25154716plk.205.2021.04.07.15.06.53; Wed, 07 Apr 2021 15:07:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=R73EQ1qQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232511AbhDGVVg (ORCPT + 99 others); Wed, 7 Apr 2021 17:21:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:42954 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232332AbhDGVVd (ORCPT ); Wed, 7 Apr 2021 17:21:33 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 61A9661175; Wed, 7 Apr 2021 21:21:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1617830482; bh=o8qxPnJ+j1q0xf7lkD4ZrFQFOtWVhbzPe6KygNi37aw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=R73EQ1qQOJLsA2EYjLE2NnBV7mRwgfgmYv9jf8VkbfbljNVMo8M7kIcQOYj3zla58 emLwyX0mRrvhc+9fhPY5ef9dLZIH0Ebk1SzJWSUReCV83bft6rQBppZY4QKSBWZzGu Bt4YqxsQbWqW0I/T+Gun1l4XHG5ABwpm+VSrk/8k= Date: Wed, 7 Apr 2021 14:21:21 -0700 From: Andrew Morton To: Nick Desaulniers Cc: Peter Oberparleiter , Nathan Chancellor , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Fangrui Song , Prasad Sodagudi , stable@vger.kernel.org Subject: Re: [PATCH 1/2] gcov: re-fix clang-11+ support Message-Id: <20210407142121.677e971e9e5dc85643441811@linux-foundation.org> In-Reply-To: <20210407185456.41943-2-ndesaulniers@google.com> References: <20210407185456.41943-1-ndesaulniers@google.com> <20210407185456.41943-2-ndesaulniers@google.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 7 Apr 2021 11:54:55 -0700 Nick Desaulniers wrote: > LLVM changed the expected function signature for > llvm_gcda_emit_function() in the clang-11 release. Users of clang-11 or > newer may have noticed their kernels producing invalid coverage > information: > > $ llvm-cov gcov -a -c -u -f -b .gcda -- gcno=.gcno > 1 : checksum mismatch, \ > (, ) != (, ) > 2 Invalid .gcda File! > ... > > Fix up the function signatures so calling this function interprets its > parameters correctly and computes the correct cfg checksum. In > particular, in clang-11, the additional checksum is no longer optional. Which tree is this against? I'm seeing quite a lot of rejects against Linus's current.