Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v1 1/2] scsi: pm8001: clean up for white space
To:     luojiaxing <luojiaxing@huawei.com>, jinpu.wang@cloud.ionos.com,
        jejb@linux.ibm.com, martin.petersen@oracle.com
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        linuxarm@huawei.com
References: <1617354522-17113-1-git-send-email-luojiaxing@huawei.com>
 <1617354522-17113-2-git-send-email-luojiaxing@huawei.com>
 <7f8aef00-07bc-6b63-19a1-85a8153387cd@acm.org>
 <3dd042b3-eb86-f0aa-5542-3f763f6830e0@huawei.com>
From:   Bart Van Assche <bvanassche@acm.org>
Message-ID: <e3532ffe-f750-5c95-7f8f-aafc86b094ca@acm.org>
Date:   Wed, 7 Apr 2021 14:56:15 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <3dd042b3-eb86-f0aa-5542-3f763f6830e0@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 4/5/21 11:39 PM, luojiaxing wrote:
> 
> On 2021/4/3 0:01, Bart Van Assche wrote:
>> On 4/2/21 2:08 AM, Luo Jiaxing wrote:
>>>   #define AAP1_MEMMAP(r, c) \
>>> -    (*(u32 *)((u8*)pm8001_ha->memoryMap.region[AAP1].virt_ptr + (r) 
>>> * 32 \
>>> +    (*(u32 *)((u8 *)pm8001_ha->memoryMap.region[AAP1].virt_ptr + (r) 
>>> * 32 \
>>>       + (c)))
>> Since this macro is being modified, please convert it into an inline
>> function such that the type of the arguments can be verified by the
>> compiler.
> 
> Sure, but still keep the function name as AAP1_MEMMAP?

The coding style requires lower case names for functions so the function 
name probably should be converted to lower case.

Thanks,

Bart.