Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 7 Apr 2021 23:41:30 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Clemens Gruber <clemens.gruber@pqgruber.com>
Cc:     linux-pwm@vger.kernel.org,
        Thierry Reding <thierry.reding@gmail.com>,
        Sven Van Asbroeck <TheSven73@gmail.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 8/8] pwm: pca9685: Add error messages for failed
 regmap calls
Message-ID: <20210407214130.6retlpofjppl3o53@pengutronix.de>
References: <20210406164140.81423-1-clemens.gruber@pqgruber.com>
 <20210406164140.81423-8-clemens.gruber@pqgruber.com>
 <20210407061619.fl6ffos6csvgtnjh@pengutronix.de>
 <YG4acW/xZS2+/kDz@workstation.tuxnet>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="qnpc6ko75vlz4xpc"
Content-Disposition: inline
In-Reply-To: <YG4acW/xZS2+/kDz@workstation.tuxnet>
Precedence: bulk


--qnpc6ko75vlz4xpc
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Clemens,

On Wed, Apr 07, 2021 at 10:47:45PM +0200, Clemens Gruber wrote:
> On Wed, Apr 07, 2021 at 08:16:19AM +0200, Uwe Kleine-K=F6nig wrote:
> > You didn't check all return codes? How did you select the calls to
> > check?
>=20
> No, because it would become a big mess and really obstruct readability
> in my opinion.
>=20
> So I chose some kind of middleground:
> I decided to check the first regmap_read and regmap_write in probe and
> return the error code if something goes wrong there.
> If something goes wrong after probe, I only print an error message.
>=20
> Is that acceptable?

I wanted to have that in the commit log, but just noticed that I didn't
read it carefully enough, it's already there.

So if you change %d in the error messages to %pe I'm happy with this
patch.

Thanks
Uwe


--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--qnpc6ko75vlz4xpc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmBuJwMACgkQwfwUeK3K
7AkELQf/aPOL73PAnyQwBMySWiPeBzJKT5lSTj+3b2tF3IVXiaB8NRko/QK04BD0
i17P0PPHdoDFupi9dOJdhuHLB5jpDddRdYmnWtqBI7NV4czNehZOWvW4D43qnFt4
tpQp54oweioxbJSBn80SNeb+V+Y8dYZCOelo9aHsqtIH5FPVYYJZZkt/+OtiFtqD
6VhKq9QshFWXWZUN/7ICmdOtoMZMA00ZMDSLaz953AOYfG6TGmrVhoVzY5YofOuw
GKQdf5INZp0xVfNHJDPWGsokkuqHE6G+YSuZYN4n6oen/5NcC9kmTdE1ON4+kQLu
QhvrHd4GFgWn2ra7uTCvAb/IkhX/Fg==
=RTFu
-----END PGP SIGNATURE-----

--qnpc6ko75vlz4xpc--