Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210331062723.2090-1-wangfangpeng1@huawei.com>
In-Reply-To: <20210331062723.2090-1-wangfangpeng1@huawei.com>
From:   Richard Weinberger <richard.weinberger@gmail.com>
Date:   Thu, 8 Apr 2021 00:11:19 +0200
Message-ID: <CAFLxGvwer-w7ngekB_4rtBLWrr0KrwqLjavJd3ZTR8Xh5f_Y3A@mail.gmail.com>
Subject: Re: [PATCH] ubifs: fix read fail but return ok
To:     wangfangpeng <wangfangpeng1@huawei.com>
Cc:     Richard Weinberger <richard@nod.at>,
        Adrian Hunter <ext-adrian.hunter@nokia.com>,
        Artem Bityutskiy <Artem.Bityutskiy@nokia.com>,
        linux-mtd@lists.infradead.org, LKML <linux-kernel@vger.kernel.org>,
        Xiaoming Ni <nixiaoming@huawei.com>, zengweilin@huawei.com,
        stable <stable@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Mar 31, 2021 at 8:29 AM wangfangpeng <wangfangpeng1@huawei.com> wrote:
> do_readpage() may return err, but ubifs_readpage() always return ok.
> The vfs will ignore the err happen in ubifs.

Are you sure about that?
In case of an error UBIFS sets the error flag of the page and does not
mark it as uptodate,
so vfs will emit -EIO. At least this is the theory. :-)

-- 
Thanks,
//richard