Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp935491pxf; Wed, 7 Apr 2021 15:29:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxdzP5qLHLc4944AMtXaH2q+jRF3FCz5JT2nXlK+og0Jwh948k12JYEgJ/rAj/VIzNfxCjT X-Received: by 2002:a05:6402:229c:: with SMTP id cw28mr7176250edb.76.1617834549465; Wed, 07 Apr 2021 15:29:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617834549; cv=none; d=google.com; s=arc-20160816; b=SvKYwd6kr6YmorKtuBxtRpuvH6+IU4Ngomt0qvEY82YluErHPNmNVIcObFoelN+LRF kH5CZe8qyILmp6HA5w+Pu9uiU+C9hGMsSHeu3Nd9EZQC8eroObDkEMA5glnDVYZqGXNo KoYWmdp7eFP6QnKASjBJgR3x1ipSiuO3bQY5sjFadp/8uDiA+ADE8zfvi0/1frHgCfs8 wvDOnkPx1g5HGPVeRa1wHDK+e0S6Ug/g7v9FsX/fN7GHk009swDTN2nLG9tN7wJFDULW TNPvgoJ3jkdl792yhDAUKLpPElTE8qU0olKR+h9HjDDZtcA/3YkkS0h0KVrkgEq0hnfs DmHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=as/0Z/5wr9TkrGQbVDRqvZhLAp0fADIbecLscNasQB0=; b=N4txr844c74Qy2J//bsPYFxHNspX/doUuJyh9krbye+IB2GBOQwUv+le0vlVMdeaMV /x51NKUA/N5fyi4/7u8Cb8+Naju0E7bGtw5PPLmLilDowQKeniSFqpYPr6DkSAbM9Uku nEgFJlikgr9UXvfEmICduQdw2G9X4Wv8yUz6RSovjpSbZZyEkLAcvd/HXDErD1gCFQ10 rRBv6TKvR+ZWKuXej8MwdYjOiH9aO13UF1IdaB7tYAghEogaWmTyxYhTumFDKnpDRq7p QOZErD2ETuwnSNcYrzkIonx0R+4E0GN7VgA5Etaa7cM3aoBYjgB5gQ/odcBGA0lnOi9b bAkg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g18si5069639ejr.315.2021.04.07.15.28.46; Wed, 07 Apr 2021 15:29:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234008AbhDGHJp (ORCPT + 99 others); Wed, 7 Apr 2021 03:09:45 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:16805 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231207AbhDGHJm (ORCPT ); Wed, 7 Apr 2021 03:09:42 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4FFb7F0k01z93y3; Wed, 7 Apr 2021 15:07:21 +0800 (CST) Received: from localhost.localdomain (10.67.165.24) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.498.0; Wed, 7 Apr 2021 15:09:26 +0800 From: Xiaofei Tan To: , CC: , , Xiaofei Tan Subject: [PATCH v3 03/10] tty: tty_jobctrl: Add a blank line after declarations Date: Wed, 7 Apr 2021 15:06:43 +0800 Message-ID: <1617779210-51576-4-git-send-email-tanxiaofei@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1617779210-51576-1-git-send-email-tanxiaofei@huawei.com> References: <1617779210-51576-1-git-send-email-tanxiaofei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add a blank line after declarations, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_jobctrl.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/tty/tty_jobctrl.c b/drivers/tty/tty_jobctrl.c index 4b751b9..86070f7 100644 --- a/drivers/tty/tty_jobctrl.c +++ b/drivers/tty/tty_jobctrl.c @@ -75,6 +75,7 @@ void proc_clear_tty(struct task_struct *p) { unsigned long flags; struct tty_struct *tty; + spin_lock_irqsave(&p->sighand->siglock, flags); tty = p->signal->tty; p->signal->tty = NULL; @@ -173,6 +174,7 @@ EXPORT_SYMBOL_GPL(get_current_tty); void session_clear_tty(struct pid *session) { struct task_struct *p; + do_each_pid_task(session, PIDTYPE_SID, p) { proc_clear_tty(p); } while_each_pid_task(session, PIDTYPE_SID, p); @@ -269,6 +271,7 @@ void disassociate_ctty(int on_exit) tty_vhangup_session(tty); } else { struct pid *tty_pgrp = tty_get_pgrp(tty); + if (tty_pgrp) { kill_pgrp(tty_pgrp, SIGHUP, on_exit); if (!on_exit) @@ -280,6 +283,7 @@ void disassociate_ctty(int on_exit) } else if (on_exit) { struct pid *old_pgrp; + spin_lock_irq(¤t->sighand->siglock); old_pgrp = current->signal->tty_old_pgrp; current->signal->tty_old_pgrp = NULL; @@ -328,6 +332,7 @@ void no_tty(void) between a new association and proc_clear_tty but possible we need to protect against this anyway */ struct task_struct *tsk = current; + disassociate_ctty(0); proc_clear_tty(tsk); } -- 2.8.1