Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp938289pxf; Wed, 7 Apr 2021 15:33:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz63NAVHi5KU1jFVqbJWZfCoqtuO5MwMNiFjbG6ScXbSX5iyoW29lyjWbHuMPP5v0mS7BRx X-Received: by 2002:a17:90a:a018:: with SMTP id q24mr5202996pjp.74.1617834839632; Wed, 07 Apr 2021 15:33:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617834839; cv=none; d=google.com; s=arc-20160816; b=KZXXcUeD5/4Qptt+wHESZOzojF+DgaWIXQat9OGUQmRfvwG+znrsjATQZK3+FB1HFl uLu4wbAgPhIDHcwsC00F9SznuO+wHqYKSGphAv618KrBtLDm5QQY8ieETQxSMyqja1Ko XWBsAKg44XPsGdfGJb0wh3U23immZyQfetVf6C4DdS/iNucSRCqeebv9xJTwlcXJjBX1 8d0q4HHij3pRd4qBOCzMk/POnRtbSGrUjWEEbskT8wXgCw+zg70u1JAu3SPzf7N1KUDz QsFpGAU3kgfML95RWDvd0jgHug8mMlNhjIA0UvUUMoKxABYytGJW9ztBwiMqXqiOcaxd adDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=HAU7PPFSktM6z24Lu4vJAUHEvEL25JNFdwQM9pPM5mM=; b=hGPsbeWiglNjpxwJfAwlaNkmILTt/L84ptzyGzfMauG+cisaxwp8uaGzMTnhBh5Zq2 Ft1nvSCi0iK/I7aGJbqwlawYiaFBoTgOtLb9MA8piFSZeuyll4zdqlA6FfIS2XaohHep FIvSHcorHm941Yfb6Z3bDT33BpWLoXqkhTLyFutuIXAPEKHQHMzsoxpnKg8krIuAdJln Unq5i6W5CibxiLB7H3umbF2W92Neo5srbrCMT1y0023XPDpm9VjacIAmNvc/kPBE5s1B eQnw/COLhyfE3qo0Gjnd4ZAFmuRmqUI54ACTjh8XAl3fBRCrnziWJ980tvQUNsDJ6L8H ys9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k6si959669pjo.52.2021.04.07.15.33.46; Wed, 07 Apr 2021 15:33:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345964AbhDGJkQ (ORCPT + 99 others); Wed, 7 Apr 2021 05:40:16 -0400 Received: from mx2.suse.de ([195.135.220.15]:49294 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345816AbhDGJjm (ORCPT ); Wed, 7 Apr 2021 05:39:42 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4A56FAF9E; Wed, 7 Apr 2021 09:38:47 +0000 (UTC) Date: Wed, 7 Apr 2021 11:38:44 +0200 From: Oscar Salvador To: Michal Hocko Cc: Mike Kravetz , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Roman Gushchin , Shakeel Butt , David Hildenbrand , Muchun Song , David Rientjes , Miaohe Lin , Peter Zijlstra , Matthew Wilcox , HORIGUCHI NAOYA , "Aneesh Kumar K . V" , Waiman Long , Peter Xu , Mina Almasry , Hillf Danton , Joonsoo Kim , Barry Song , Will Deacon , Andrew Morton Subject: Re: [PATCH v4 7/8] hugetlb: make free_huge_page irq safe Message-ID: <20210407093844.GB11066@linux> References: <20210405230043.182734-1-mike.kravetz@oracle.com> <20210405230043.182734-8-mike.kravetz@oracle.com> <20210407091237.GC10058@linux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 07, 2021 at 11:33:18AM +0200, Michal Hocko wrote: > Yes. spin_unlock_irq will enable interrupts unconditionally which is > certainly not what we want if the path is called with IRQ disabled by > the caller. I see, thanks for confirming. -- Oscar Salvador SUSE L3