Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp941091pxf; Wed, 7 Apr 2021 15:38:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzTvETZd4Uskyx9DokMVSjDRVhaT/ZjCg86umjcAsARujiSpehPSg8MCiD1wE8/paaT7P5F X-Received: by 2002:a17:906:5356:: with SMTP id j22mr6381405ejo.308.1617835117016; Wed, 07 Apr 2021 15:38:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617835117; cv=none; d=google.com; s=arc-20160816; b=PehjhSKMiiSdu6BCLmny6kIiG5GWHt5CjfomXOASuIUufjyskj5grr72QyKHy7bqkP u+95AcUJmmT5V+u/997PqF2Kl5ZdE5viTi2eGbA3R2d64HRmJP+uZgD1+D2E39XNCNRg mdCZe8EYVMbOd1wtZ4mbROv4VpbruYP6u9yNL6DH6S6hrucDfihqoqnIEAQCYURTkw+s OxkEH8sMJDqSqKqdxinqkdMJCXB/e1+l577yfiX8Xgs+NMkJpw97gHNLpgdmQ21DgLXc hq/OYChibH0cr3xF32x1NS1WheTBMZswbF12gIYxz2FL3Cnz4lyWkWACgid4ZgmRJRK3 Am5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=B8lkpnnUB1rBYTs5Pcw8rJJgbH/kEsdiVwIyaTycFCA=; b=TeStgvOYoqiWtmeZdwMHOm5zI7IQJDnNMcGrrmZDkCrx4v2iVwSWf+ggdVMdJNahk8 g3ObV8M0iU0b3oZUzjpgdbK+zfJdaji4l6tjDP5TkvVEjaDSFXy3hBT9LqdbWClKg2Nf n43ZZifCDdcN6DBmJR/Mq7OWa825u0uVMwqYIifvtMnVBO2OqahUBF83RbdBArzvsi+9 UEZlXPIC+//fzay0NQfeKIA3e3RVTHWSWnMnZcXrKNodU4JZHh5TvG+mqRN5pjnL9sty n54L9QXTou4kTrFxvTt4B6acOg/izBW/y0nOOPCRYO5Zb1Lpi/Sv5NZFtAzZ9B0zlQhW Qs5w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c9si14200631eds.318.2021.04.07.15.38.14; Wed, 07 Apr 2021 15:38:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244495AbhDGOwX (ORCPT + 99 others); Wed, 7 Apr 2021 10:52:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:55516 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232041AbhDGOwW (ORCPT ); Wed, 7 Apr 2021 10:52:22 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 19AB961363; Wed, 7 Apr 2021 14:52:13 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=hot-poop.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lU9XN-00665o-Vi; Wed, 07 Apr 2021 15:52:10 +0100 From: Marc Zyngier To: Eric Auger , kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, alexandru.elisei@arm.com, drjones@redhat.com, eric.auger.pro@gmail.com, linux-kernel@vger.kernel.org Cc: james.morse@arm.com, suzuki.poulose@arm.com, pbonzini@redhat.com, shuah@kernel.org Subject: Re: [PATCH] KVM: selftests: vgic_init kvm selftests fixup Date: Wed, 7 Apr 2021 15:52:04 +0100 Message-Id: <161780711779.1927596.2664047995521276237.b4-ty@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210407135937.533141-1-eric.auger@redhat.com> References: <20210407135937.533141-1-eric.auger@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: eric.auger@redhat.com, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, alexandru.elisei@arm.com, drjones@redhat.com, eric.auger.pro@gmail.com, linux-kernel@vger.kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, pbonzini@redhat.com, shuah@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 7 Apr 2021 15:59:37 +0200, Eric Auger wrote: > Bring some improvements/rationalization over the first version > of the vgic_init selftests: > > - ucall_init is moved in run_cpu() > - vcpu_args_set is not called as not needed > - whenever a helper is supposed to succeed, call the non "_" version > - helpers do not return -errno, instead errno is checked by the caller > - vm_gic struct is used whenever possible, as well as vm_gic_destroy > - _kvm_create_device takes an addition fd parameter Applied to kvm-arm64/vgic-5.13, thanks! [1/1] KVM: selftests: vgic_init kvm selftests fixup commit: 4cffb2df4260ed38c7ae4105f6913ad2d71a16ec Cheers, M. -- Without deviation from the norm, progress is not possible.