Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp941143pxf; Wed, 7 Apr 2021 15:38:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx099s8fvZUcW6jIez7VhRENUHS4fi8AfrsVa78bjLEGmenoRqE7/LKbg46c5uoVPBK+mTi X-Received: by 2002:a17:906:c206:: with SMTP id d6mr3813867ejz.531.1617835120905; Wed, 07 Apr 2021 15:38:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617835120; cv=none; d=google.com; s=arc-20160816; b=Jy/KcPYtebQa2/PcheGRjmMOGS6ahO41YKorouiwLaBooe2XbcCdODYT5GC5AuULRD dwcPhXBSGcv85zk3xz6OV8EWwM+FlFHRfy9hJo6/BZ8MyiG742nPOCgy+rs8VFrXRiBv JMyYEOeIcRCD5qhssxZ/6cF0dWp0rvREJfPEMqdxk7O5yHMRsHs22fxFQC80Fk7hVqS8 eojJG0nNmljxwJ+3LnLNacFvPiIpwinF7665E1POLxwqyTRoiF/yB/0JmfqblHXEpTk/ RJbdH/Xm27LtEkpgimiA7yObHU3HbJPb5Kfpx1m3q6EO+z1Ul0wk02ks0lMOqBKAcdof jZHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=NV0cjIfV44T3djaFfL14Vm0DDAFZg2rELZHNBXFE/VQ=; b=YhYXtToANBEXQH+u0mgJrwaHsjTqEeKO3eI1hy8hTRCkyuQ3iHrBgHokOO5GGC8SUt XBH1AH9yxFOSSbZpPV1yXA/9Ulu2Y+DP5dpw5xOUVdaR7x6OrnnF0FV9Mo+k1Jgzladf ZhUNOLG5I8fK4R9zDAdjOsk2Z45DYvmQrRZ7QvQqFcmFKMlDjRpzWF5rnllWS5N2ND4a ymqxnHrP3kBpOcIFsBk6NM5KcaXkUSWPPLDbTUOI9ekXLfPLEEY6Hy+/y+O7qVfj1p3p 8I69takGZh0m9NEu1XXo70yF8jSr4l5wrmxe4Van9uqszpnRJmeKN7ObpAIfM/j5M0DI 04WQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BF4g7p0G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ce25si11183931ejb.93.2021.04.07.15.38.18; Wed, 07 Apr 2021 15:38:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BF4g7p0G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347181AbhDGPQF (ORCPT + 99 others); Wed, 7 Apr 2021 11:16:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:35088 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232221AbhDGPQB (ORCPT ); Wed, 7 Apr 2021 11:16:01 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5764B61222; Wed, 7 Apr 2021 15:15:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617808551; bh=94PRIMWG4V3sgv4oARYxnmjhrvLu3NubLdmmO0Dgjuo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BF4g7p0GvM/lL5494Bp3z0or+u55EH1ofQEvNHjxLj+3XFtOLnH2ISD6pmDUnUq+I gHc6wiOwVnWBBjROSmxmEaPuvwrp6DcXa5bIjh3wt5+fMj7OCH101qsGf9hQhIsV2Q QIfX4rbNgx2fI4DZ+ET4nYzsuXX8z1FLgecYf0yZpybvjzQFDrDKMM+uqKUOVUxQwP 0gRQX1u5wM0ZV1ly4QlWEuzuD53BmxKwIJ5YiXHZSGafS5a8bI765b+sJddaXfL81F tnZB8N/hcv/RQrQNyzNfv89gpLntv/UML2/GLiJ3qGVRfolY0V/Y5VzJw2VsAUJ1L6 y8MSVCCUIPiew== Date: Wed, 7 Apr 2021 16:15:34 +0100 From: Mark Brown To: Perry Yuan Cc: pobrn@protonmail.com, pierre-louis.bossart@linux.intel.com, oder_chiou@realtek.com, perex@perex.cz, tiwai@suse.com, hdegoede@redhat.com, mgross@linux.intel.com, Mario.Limonciello@dell.com, lgirdwood@gmail.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, mario.limonciello@outlook.com, Dell.Client.Kernel@dell.com Subject: Re: [PATCH v6 2/2] ASoC: rt715:add micmute led state control supports Message-ID: <20210407151534.GE5510@sirena.org.uk> References: <20210404083159.1620-1-Perry_Yuan@Dell.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4Epv4kl9IRBfg3rk" Content-Disposition: inline In-Reply-To: <20210404083159.1620-1-Perry_Yuan@Dell.com> X-Cookie: Dry clean only. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --4Epv4kl9IRBfg3rk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Apr 04, 2021 at 04:31:59PM +0800, Perry Yuan wrote: > +static bool micmute_led_set; > +static int dmi_matched(const struct dmi_system_id *dmi) > +{ > + micmute_led_set = 1; > + return 1; > +} This isn't how we usually record DMI quirks, usually we'd query once on probe and store the data in the driver data struct - see other users for examples. > @@ -358,6 +388,7 @@ static int rt715_sdca_put_volsw(struct snd_kcontrol *kcontrol, > unsigned int mask = (1 << fls(max)) - 1; > + dmi_check_system(micmute_led_dmi_table); > + if (invert && micmute_led_set) { This check for invert is odd and could probably use a comment. --4Epv4kl9IRBfg3rk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmBtzJUACgkQJNaLcl1U h9Dpcwf9F6efsgl8SxB48L2h93SnAp+aXJZGvsihl3talmxVNg7zmoGcUoHsDMU8 Q48ZaYHXa2Zehw7UMpBlQ1Iww60W43c3yVSv5xS9C5FZdr7pvn0fjVhVX121uSTt BeTI2r8BH0ndjb29prof+duUTHGBx+I81NjAC7aK26EIcnkHZqREM1dhVbJtSd+I p+ofEZVpTswy5qECN1/JtYf6QvlRJ3x0QOCaq8E4Sj1URTRP3NCMSJH9h/WaItae sJvELh1IcUMel0ElT1TEtf/fgDZVgiQh3PmRkA6qtrqturKrWSw61T99EE80Rn7j ZsK6s1vQEXo5vslhtx5JoOGtK8wDTQ== =w3kO -----END PGP SIGNATURE----- --4Epv4kl9IRBfg3rk--