Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <1bbc36d5fbc74f11b2a1c0d3255bb3394a048a20.camel@perches.com>
Subject: Re: [RESEND PATCH v1] checkpatch: exclude four preprocessor
 sub-expressions from MACRO_ARG_REUSE
From:   Joe Perches <joe@perches.com>
To:     Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
        Andy Whitcroft <apw@canonical.com>,
        linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>
Date:   Wed, 07 Apr 2021 10:47:50 -0700
In-Reply-To: <20210407105042.25380-1-mailhol.vincent@wanadoo.fr>
References: <20210407105042.25380-1-mailhol.vincent@wanadoo.fr>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.38.1-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, 2021-04-07 at 19:50 +0900, Vincent Mailhol wrote:
> __must_be_array, offsetof, sizeof_field and __stringify are all
> preprocessor macros and do not evaluate their arguments. As such, it
> is safe not to warn when arguments are being reused in those four
> sub-expressions.
> 
> Exclude those so that they can pass checkpatch.
> 
> Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>

Acked-by: Joe Perches <joe@perches.com>

> ---
> ?scripts/checkpatch.pl | 2 +-
> ?1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index df8b23dc1eb0..25ee4fd5b118 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -5736,7 +5736,7 @@ sub process {
> ?			        next if ($arg =~ /\.\.\./);
> ?			        next if ($arg =~ /^type$/i);
> ?				my $tmp_stmt = $define_stmt;
> -				$tmp_stmt =~ s/\b(sizeof|typeof|__typeof__|__builtin\w+|typecheck\s*\(\s*$Type\s*,|\#+)\s*\(*\s*$arg\s*\)*\b//g;
> +				$tmp_stmt =~ s/\b(__must_be_array|offsetof|sizeof|sizeof_field|__stringify|typeof|__typeof__|__builtin\w+|typecheck\s*\(\s*$Type\s*,|\#+)\s*\(*\s*$arg\s*\)*\b//g;
> ?				$tmp_stmt =~ s/\#+\s*$arg\b//g;
> ?				$tmp_stmt =~ s/\b$arg\s*\#\#//g;
> ?				my $use_cnt = () = $tmp_stmt =~ /\b$arg\b/g;