Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Min Li <min.li.xe@renesas.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "derek.kiernan@xilinx.com" <derek.kiernan@xilinx.com>,
        "dragan.cvetic@xilinx.com" <dragan.cvetic@xilinx.com>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next v2 2/2] misc: Add Renesas Synchronization
 Management Unit (SMU) support
Thread-Topic: [PATCH net-next v2 2/2] misc: Add Renesas Synchronization
 Management Unit (SMU) support
Thread-Index: AQHXK9TmRDzfnJqVl0Sq9GK4xidseaqpVJQAgAAj8wA=
Date:   Wed, 7 Apr 2021 20:00:38 +0000
Message-ID: <OSBPR01MB4773A83DF7D1CDA4DBFD9E84BA759@OSBPR01MB4773.jpnprd01.prod.outlook.com>
References: <1617816815-3785-1-git-send-email-min.li.xe@renesas.com>
 <1617816815-3785-2-git-send-email-min.li.xe@renesas.com>
 <YG3wRJnootNdV0cc@kroah.com>
In-Reply-To: <YG3wRJnootNdV0cc@kroah.com>
Accept-Language: en-CA, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d8927843-2415-49aa-c2c8-08d8f9ffd0ed
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2021 20:00:38.8965
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pQn23dKzZf0Ppn/f0DX65on7x02DV1jQU81V6HCWogg3JpKuJW2pUlpPSgFxqNixR89HglAS0nZT07j+STpnxA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSAPR01MB5058
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> Do you really meen "+" here?  (sorry, have to ask.)
>=20

I don't know. All of our Linux kernel code has GPL-2.0+ and I just blindly =
inherit it.

> > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>=20
> You should not need this as it's a driver, so you should only use the
> dev_dbg() family of print message functions, no need for pr_*() calls.
>=20
I have one call to pr_err in rsmu_init

pr_err("Unabled to register %s platform driver", DRIVER_NAME);=20