Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp957636pxf; Wed, 7 Apr 2021 16:06:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyiK8iP+MAxWYrHR28bhjT+DJ3YuUtkSN6rsxcqweJM5n8BPgr3Qc4i55mDZxOpiL5D5UNX X-Received: by 2002:aa7:cf02:: with SMTP id a2mr7311154edy.59.1617836776291; Wed, 07 Apr 2021 16:06:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617836776; cv=none; d=google.com; s=arc-20160816; b=XGsaCO+eUsCkGRcNDBnV85D1CjZJZkygYlSmKP+NVF477UWTeT0XXvp7AtU7WJYQ9v oyV0D7vVDT6fBFKKxs+0hRt/hcAHFctgB+EhC2/p944550eWpg9IUp7/dp/HG5Rawps5 4w//XUNsQQ/uM2Qazm+uTyzwgdT7gGvnc3ICOR4G06fRLOTdaRZ/Iy/hyzIevz0QC1yy nb5cwka1SHE1FELr9uxh+N8spOBIrRz9s5Bv7g1iZiSjNr7kSZdLEOuMg9FsjyrSNxhA jY2s8PfM13jI8zBeAkDrTAw57LPV2I/CSiMSc9DTBF1DeSHz8LAgAwpNPtMbAqCfAE4q 2+SA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :dkim-signature; bh=hwoYrwOq9pLEpar1NO7OjTnNO97Ou5obMzbFZrY0SaQ=; b=tZaQkfxEDCjy00L9Fj3EGhnsHyypyjerW0f64E8wSWsouxPD/dYoYiZglrBEoIbHB/ HvADkk1vKiHyvHG9OwbNX8RmaDMD5QFV9CbYWiFpF4982Uag6g4eyc00YP1Wba3ZhPbi pKQ/TTwbeAZCiupT0YgtEa2JOxaFCC3X+gDMsg3oyhtUzxoxKelY85jisLIJRvVXahQ+ 0CELv5uyHjxkweQtorHe3bzFA1hUOcN5iioDCo20GZhIeYzJ7K82CcMmrRIx0z+m3N4p hcSRJbdXHM5OMnV/3iHynMD0GaXDej1EzMDMsko3VBb+bQdFAa14K7X+mlRVmMXSkKj5 c1Tw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=McXKbWlO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cw12si9016339edb.475.2021.04.07.16.05.52; Wed, 07 Apr 2021 16:06:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=McXKbWlO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229686AbhDGXEf (ORCPT + 99 others); Wed, 7 Apr 2021 19:04:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:60396 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229488AbhDGXEe (ORCPT ); Wed, 7 Apr 2021 19:04:34 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A236B61181; Wed, 7 Apr 2021 23:04:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617836664; bh=hwoYrwOq9pLEpar1NO7OjTnNO97Ou5obMzbFZrY0SaQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=McXKbWlO+zmMzPpITR3Lmdc2PnVwwHekVl14v00WLX4jFVqL+hed7Uy2Ggr9R74kX hnSlObbb2CkFeYgcGvNA4lhPI0tD0zsz+DYbdcmT7b4z+MwmdiAP1sW4MseU3WIbvk klEkvhH1+tJyro+ISP57oqTy+lD5tqZqk36Oh+GUVeiLwBlhRNZOcInItxsJ6+o8Bl ieAmjDNLx2KFlIEWMydigNMwBECO8R/LQz+uGQI3ECbe+qS3uXS3WrR9IIBbTEZ67k Z4a0OTCkbnueleL/IlzCfW/8hPWx3QYO8LERCpFjx+TD/U25Dt9V3sPqyzQiSNTMSb F6fxJolieIpEg== Date: Thu, 8 Apr 2021 01:04:21 +0200 From: Wolfram Sang To: Jarkko Nikula Cc: Yicong Yang , andriy.shevchenko@linux.intel.com, linux-i2c@vger.kernel.org, Sergey.Semin@baikalelectronics.ru, linux-kernel@vger.kernel.org, digetx@gmail.com, treding@nvidia.com, rmk+kernel@armlinux.org.uk, song.bao.hua@hisilicon.com, john.garry@huawei.com, mika.westerberg@linux.intel.com, prime.zeng@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH v6 3/5] i2c: add support for HiSilicon I2C controller Message-ID: <20210407230421.GB860@kunai> Mail-Followup-To: Wolfram Sang , Jarkko Nikula , Yicong Yang , andriy.shevchenko@linux.intel.com, linux-i2c@vger.kernel.org, Sergey.Semin@baikalelectronics.ru, linux-kernel@vger.kernel.org, digetx@gmail.com, treding@nvidia.com, rmk+kernel@armlinux.org.uk, song.bao.hua@hisilicon.com, john.garry@huawei.com, mika.westerberg@linux.intel.com, prime.zeng@huawei.com, linuxarm@huawei.com References: <1617197790-30627-1-git-send-email-yangyicong@hisilicon.com> <1617197790-30627-4-git-send-email-yangyicong@hisilicon.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GRPZ8SYKNexpdSJ7" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --GRPZ8SYKNexpdSJ7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > Reason for temp variable is for me it's confusing to see statement like > "rate_khz = rate_khz / 1000". Yes. And with this clearer calculation, we can maybe skip the HZ_PER_KHZ define completely and just use plain '1000' as a factor/divider because it then becomes obvious. I still find the define more confusing than helpful TBH. But I'll leave the final decision to Yicong Yang. --GRPZ8SYKNexpdSJ7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmBuOnQACgkQFA3kzBSg KbZEPQ//czAF//Y5lGA+H8Rp1n68T3nNiA6rmBKuPZFX/qmqGVCJPG8filxwrP+i ibtGyvuQhjdlcYtDwlCnrI4KuuyUDLsHN8jgk8F028ZNUlFD7jqjHFa1h6XHzd2l 3petiBjmJPFBoJdoSR5W8qWXvTxlex+fi9d/Rf4kdsppGfz/7gN1GI7JzCk3crx+ xkZz8SOWNfteTLg0n+kSU5YrKC/lEbab4DuDxLSu09UJMuHi3OLtI++MNjJuZ6RT dd5OhcMIQ/IRcjG7WCqD9+sUYlWlaXldLiUR6OlWtKka4PM3SubMgUXjhFIimOwU ppknmefPGgyM+GeZ+eg21xR1/Vj6s6plfIuIbRsUAvt8BRznixgpXWLMM/xSLDQg s6aJDL6dI9WhBnUhM35Bb34Ui6ri9DwYZmzY8eRI78tfD07OM9xs2qBZDJIunvF7 lukNPmiroSyjprRqFEQRb38fEt4kHx0eBwFWbjmwtTnetVRralkkymxN+YwQLl5G qihhcGazUqiKD4KcQ7QZYKJMgTLy5/1kcvGX6bOdTo82tE+IDgvjsf0G95OWmY0b GJkvUgCce1IWDeQMnONRrmYPL+sc7RgJ4gfOZfw7fuxbztRax6/J/tBUE6GnC/iJ 7iYdIbGmFhB76zrHZIvxTPQlUJSnFpyjsYFwAqLEQPLsicAknaU= =d+oE -----END PGP SIGNATURE----- --GRPZ8SYKNexpdSJ7--