Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <alpine.DEB.2.22.394.2104072100410.11549@hadrien>
References: <alpine.DEB.2.22.394.2104072100410.11549@hadrien>
Subject: Re: [PATCH] clk: fix for_each_child.cocci warnings
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, robh+dt@kernel.org,
        kbuild-all@lists.01.org
To:     Julia Lawall <julia.lawall@inria.fr>,
        Liam Beguin <liambeguin@gmail.com>, mturquette@baylibre.com
Date:   Wed, 07 Apr 2021 17:31:13 -0700
Message-ID: <161784187378.3790633.2593540922159647609@swboyd.mtv.corp.google.com>
User-Agent: alot/0.9.1
Precedence: bulk

Quoting Julia Lawall (2021-04-07 12:02:32)
> From: kernel test robot <lkp@intel.com>
>=20
> For_each_child_of_node should have of_node_put() before goto.
>=20
> Generated by: scripts/coccinelle/iterators/for_each_child.cocci
>=20
> CC: Liam Beguin <lvb@xiphos.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
> ---

Is this a fix for a patch on the list?

>=20
> url:    https://github.com/0day-ci/linux/commits/Liam-Beguin/add-support-=
for-the-lmk04832/20210407-085408
> base:   f40ddce88593482919761f74910f42f4b84c004b
> :::::: branch date: 9 hours ago
> :::::: commit date: 9 hours ago
>=20
>  clk-lmk04832.c |    1 +
>  1 file changed, 1 insertion(+)
>=20
> --- a/drivers/clk/clk-lmk04832.c
> +++ b/drivers/clk/clk-lmk04832.c
> @@ -1159,6 +1159,7 @@ static int lmk04832_probe(struct spi_dev
>                 if (ret) {
>                         dev_err(lmk->dev, "missing reg property in child:=
 %s\n",
>                                 child->full_name);
> +                       of_node_put(child);
>                         goto err_disable_oscin;
>                 }
>